hannahs@ - I have a few questions regarding to how JS dialogs should be handled in various cases:
1) Can url bar be focused? If the url bar is focused and user doesn't navigate to a different url, should we dismiss the dialog or keep it shown?
2) Should the dialog be dismissed when user goes to tab switcher but chooses that same tab again?
3) For Chrome Home, how should we handle swipe up to open bottom sheet when dialog is showing? Should we just disable it?
Hi! Some quick answers in line:
1) Can url bar be focused? If the url bar is focused and user doesn't navigate to a different url, should we dismiss the dialog or keep it shown?
I assume the original designer allowed for this for security reasons (can the user dismiss the dialog by tapping the scrim?) The pattern should probably be the same as the translate infobar -when the url bar is focused but the user returns the dialog reappears.
2) Should the dialog be dismissed when user goes to tab switcher but chooses that same tab again?
Lets follow the same pattern as above where the dialog reappears when the tab is re-selected.
3) For Chrome Home, how should we handle swipe up to open bottom sheet when dialog is showing? Should we just disable it?
Lets use the same pattern as above again, where it gets replaced by the bottom sheet but reappears if the user swipes back down.
Thanks for the response!
Re #8:
1) The user cannot dismiss the dialog by tapping the scrim. Currently I made the dialog stays at behind the url bar and the url suggestions when url bar is focused. That's the same behavior on desktop. Is that okay? If we decide not to follow desktop, the behavior you suggest is okay too.
2) Yes I think we can do that.
3) Again the dialog is currently made behind the bottom sheet if bottom sheet is opened. When bottom sheet is closed, the dialog is brought to the front again.
Some more questions:
4) If bottom sheet is showing before dialog is shown, should we immediately show the dialog and close the bottom sheet for the user, or, show the dialog behind bottom sheet and bring it up front once bottom sheet is closed by user (or show the dialog after bottom sheet is closed)?
5) Should we consider overlapping toolbar more for multi-window mode on small screens since the dialog is really small, or having the toolbar accessible is a must in all situations?
1-3 lgtm!
4) If bottom sheet is showing before dialog is shown, should we immediately show the dialog and close the bottom sheet for the user, or, show the dialog behind bottom sheet and bring it up front once bottom sheet is closed by user (or show the dialog after bottom sheet is closed)?
Lets show it after the bottom sheet is closed so it doesn't seem like the site is taking action while the user is in CH.
5) Should we consider overlapping toolbar more for multi-window mode on small screens since the dialog is really small, or having the toolbar accessible is a must in all situations?
Would I be able to ask for a quick screenshot/video here? Since the user can't dismiss the dialog by tapping the scrim the toolbar is the only way out if the user doesn't want to take any action which is why (I believe) it was kept in. Can anyone confirm if this is true?
Sorry - just jumping on the backlog of emails. This LGTM. For small screens, what happens if we overflow the screen size? do we just force the content to scroll?
Re #10: Screenshot attached is showing the multi-window mode javascript prompt dialog. Since there is a text editting box, the message box becomes really small and nearly unreadable.
Currently, it seems like dialogs either resize to a smaller width (as in the case with add to home) or it does what you've screenshot'd above (except that the scroll bar is visible + div line above the buttons to let the user know you there's more content on scroll.
Can we do the same here? (resize when there's no image, and scroll bar + div line when there are?)
There is actually a scrollbar for the description part on the screenshot in #12, but seems only visible when you scroll it. In #13, do you mean that we want to make the title also scrollable with the message?
Sorry I meant that the scrollbar should always be visible when the dialog is cut off (not only on scroll). I think it also makes sense to make the title scrollable (I believe it'a also what we did for the data saver promo so lets do that). Thanks!
Comment 1 by rolfe@chromium.org
, Mar 22 2017