New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 687002 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 687258
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

memory.top_10_mobile_stress failing on 13 builders on chromium.perf

Project Member Reported by martiniss@chromium.org, Jan 31 2017

Issue description

memory.top_10_mobile_stress failing on 13 builders

Relevant stack trace: 

File "/b/s/w/ira3kkbe/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 94, in _RunStoryAndProcessErrorIfNeeded
state.RunStory(results)
File "/b/s/w/ira3kkbe/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
return func(*args, **kwargs)
File "/b/s/w/ira3kkbe/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 299, in RunStory
self._current_page.Run(self)
File "/b/s/w/ira3kkbe/third_party/catapult/telemetry/telemetry/page/__init__.py", line 111, in Run
self.RunPageInteractions(action_runner)
File "/b/s/w/ira3kkbe/tools/perf/page_sets/memory_top_10_mobile.py", line 54, in RunPageInteractions
android_browser.Background()
File "/b/s/w/ira3kkbe/third_party/catapult/telemetry/telemetry/internal/browser/browser.py", line 277, in Background
return self._browser_backend.Background()
File "/b/s/w/ira3kkbe/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
return func(*args, **kwargs)
File "/b/s/w/ira3kkbe/third_party/catapult/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py", line 606, in Background
raise NotImplementedError
NotImplementedError

The NotImplementedError was added in https://github.com/catapult-project/catapult/commit/d489dd8dabbfa788b7eb3c0d0979b165aead0eb1. Unsure exactly why this was triggered recently.

Via a casual glance, I see https://chromium.googlesource.com/chromium/src/+/99a75259cfd52d1390fc0733f9dc18326c819f6f as a potential culprit. It only touches android code though, so I'm not sure why it would affect mostly desktop tests. (Affected builders are only desktop browsers).
 
Cc: mikec...@chromium.org
Looked at https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf/builds/295 for the blamelist. It's a reliable failure.
Owner: mikec...@chromium.org
This is almost definitely related to this CL I landed....
https://codereview.chromium.org/2652343004

In this CL I removed changed the ShouldDisable() method. My guess is that this test did not previously run on the bots it is now failing on.

Pretty sure this should only be running on Android
Yes, previously, test was triggered but this showed up in logs....
memory.top_10_mobile_stress is disabled on the selected browser

Now the test is triggered and tries to run. Is it expected that all these mobile tests are triggered on desktop bots? 



Status: Started (was: Available)
Mergedinto: 687258
Status: Duplicate (was: Started)

Sign in to add a comment