Search-L shortcut fails to lock screen when the focus is in an input field with IME enabled |
||||||||||||||
Issue descriptionChrome Version: 56.0.2924.79 beta OS version: 9000.76.0 What steps will reproduce the problem? (1) switch to Japanese IME (2) ctrl-search-L to lock screen What is the expected result? Screen is locked What happens instead? 'L' is entered. Please use labels and text to provide additional information. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Feb 7 2017
Yingbing, can you please take a look? Thanks.
,
Feb 15 2017
Hi Shu, The root cause is: When user hold "search" key, then press "L". Input API doesn't pass "search" key state, it only pass normal "L" key. I suggest set "metaKey" as true when pass "L" keydown event.
,
Feb 20 2017
,
Feb 20 2017
,
Feb 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fbd37145e9b8eb98e1e5b330364db3fd07dd719 commit 6fbd37145e9b8eb98e1e5b330364db3fd07dd719 Author: shuchen <shuchen@chromium.org> Date: Mon Feb 20 08:06:52 2017 Don't handle the key events with Command (Search) modifier by IME. BUG= 686997 Review-Url: https://codereview.chromium.org/2704993002 Cr-Commit-Position: refs/heads/master@{#451579} [modify] https://crrev.com/6fbd37145e9b8eb98e1e5b330364db3fd07dd719/chrome/browser/ui/input_method/input_method_engine_base.cc
,
Feb 20 2017
,
Feb 20 2017
,
Feb 21 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2fc4244045288217b0b05f5433747263caa8361 commit d2fc4244045288217b0b05f5433747263caa8361 Author: Shu Chen <shuchen@google.com> Date: Tue Feb 21 11:01:36 2017 Don't handle the key events with Command (Search) modifier by IME. BUG= 686997 Review-Url: https://codereview.chromium.org/2704993002 Cr-Commit-Position: refs/heads/master@{#451579} (cherry picked from commit 6fbd37145e9b8eb98e1e5b330364db3fd07dd719) Review-Url: https://codereview.chromium.org/2708853003 . Cr-Commit-Position: refs/branch-heads/2987@{#606} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/d2fc4244045288217b0b05f5433747263caa8361/chrome/browser/ui/input_method/input_method_engine_base.cc
,
Feb 21 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by mitsuji@chromium.org
, Jan 31 2017Status: Assigned (was: Untriaged)