Harmony close buttons should be 16 DIP/side, not 24 |
||||||
Issue descriptionCurrent Harmony close buttons are 24 DIP per side (since they are VectorIconButtons, and all such buttons are 24 DIP). The spec says to use 16. Open questions for Alan: * Should other such icon buttons also be 16? For example, the find next/previous "arrow" buttons in the find box. My patch to fix this changes these as well. This seems likely correct to me (it would be weird to have three icons in a row, but the third has a smaller target), but I'm a little leery of the sort of fixed-size assumptions I'm seeing in the code. * Playing with these close buttons for only a few minutes, the hover targets feel *really* small at 16 px. I'm worried about a11y here in particular. Compare to e.g. Windows native where window close button targets are humongous (~45x29 on Win 10), we're going from something that's about 1/2 the window close button area to something that's about 1/5th the close button area. It feels a little tricky to target to me. How much practical testing have we already done here to feel confident of this choice? What sort of testing/considerations should we give as/after we land, to make sure we stay happy with it?
,
Jan 31 2017
16px is too small to be a reasonable click target, I think. We should bring this up on the chrome-harmony list.
,
Feb 1 2017
Raising to P1, because even if we decide this size works for mouse, we may want something different for touch. That sort of thing should be determined now so we have time to architect correctly.
,
Feb 14 2017
->bettes to at least answer the stuff in comment 0 and to consider a11y and touch in general.
,
Feb 14 2017
,
Feb 14 2017
,
Apr 11 2017
The spec here is now that close buttons should be 24 DIP. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jan 31 2017