New issue
Advanced search Search tips

Issue 686958 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Clean up FeatureProvider

Project Member Reported by rdevlin....@chromium.org, Jan 31 2017

Issue description

FeatureProvider needs some cleanup.  e.g. removing BaseFeatureProvider, since there's only ever one implementation.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68806fb06d73fe2867a7063ef29654406a0c5819

commit 68806fb06d73fe2867a7063ef29654406a0c5819
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Tue Jan 31 14:30:33 2017

[Extensions] Remove BaseFeatureProvider

BaseFeatureProvider is the implementation of FeatureProvider, but it's
also the only implementation. Simply combine it and FeatureProvider, and
remove BaseFeatureProvider and its references.

BUG=686958
TEST=None, no functional change

Review-Url: https://codereview.chromium.org/2669463002
Cr-Commit-Position: refs/heads/master@{#447231}

[modify] https://crrev.com/68806fb06d73fe2867a7063ef29654406a0c5819/chrome/browser/extensions/api/cast_streaming/performance_test.cc
[modify] https://crrev.com/68806fb06d73fe2867a7063ef29654406a0c5819/chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc
[modify] https://crrev.com/68806fb06d73fe2867a7063ef29654406a0c5819/chrome/common/extensions/api/_api_features.json
[modify] https://crrev.com/68806fb06d73fe2867a7063ef29654406a0c5819/chrome/common/extensions/api/_manifest_features.json
[modify] https://crrev.com/68806fb06d73fe2867a7063ef29654406a0c5819/chrome/common/extensions/api/_permission_features.json
[modify] https://crrev.com/68806fb06d73fe2867a7063ef29654406a0c5819/extensions/browser/api/system_cpu/system_cpu_api.cc
[modify] https://crrev.com/68806fb06d73fe2867a7063ef29654406a0c5819/extensions/common/BUILD.gn
[modify] https://crrev.com/68806fb06d73fe2867a7063ef29654406a0c5819/extensions/common/api/_api_features.json
[modify] https://crrev.com/68806fb06d73fe2867a7063ef29654406a0c5819/extensions/common/api/_behavior_features.json
[modify] https://crrev.com/68806fb06d73fe2867a7063ef29654406a0c5819/extensions/common/api/_manifest_features.json
[modify] https://crrev.com/68806fb06d73fe2867a7063ef29654406a0c5819/extensions/common/api/_permission_features.json
[delete] https://crrev.com/a4b96272c745c096c11b55f4f7a33b3d1b766101/extensions/common/features/base_feature_provider.cc
[delete] https://crrev.com/a4b96272c745c096c11b55f4f7a33b3d1b766101/extensions/common/features/base_feature_provider.h
[modify] https://crrev.com/68806fb06d73fe2867a7063ef29654406a0c5819/extensions/common/features/feature_provider.cc
[modify] https://crrev.com/68806fb06d73fe2867a7063ef29654406a0c5819/extensions/common/features/feature_provider.h
[rename] https://crrev.com/68806fb06d73fe2867a7063ef29654406a0c5819/extensions/common/features/feature_provider_unittest.cc
[modify] https://crrev.com/68806fb06d73fe2867a7063ef29654406a0c5819/extensions/common/features/simple_feature.h
[modify] https://crrev.com/68806fb06d73fe2867a7063ef29654406a0c5819/extensions/renderer/script_context.cc
[modify] https://crrev.com/68806fb06d73fe2867a7063ef29654406a0c5819/extensions/shell/common/api/_api_features.json
[modify] https://crrev.com/68806fb06d73fe2867a7063ef29654406a0c5819/tools/json_schema_compiler/feature_compiler.py

Sign in to add a comment