Refactor of SetupConnectedItemMd() functions for Ash MD system menu |
|||||||||
Issue descriptionThere is a SetupConnectedItemMd() function in both ash/common/system/chromeos/network/network_state_list_detailed_view.cc and ash/common/system/chromeos/network/vpn_list_view.cc. These should ideally share code with the corresponding function in ash/common/system/chromeos/bluetooth/tray_bluetooth.cc.
,
Mar 7 2017
,
Apr 25 2017
,
Apr 28 2017
,
May 24 2017
,
May 25 2017
,
May 25 2017
,
May 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33fcecd6c91552f374b30b153d7a914bd74d52e8 commit 33fcecd6c91552f374b30b153d7a914bd74d52e8 Author: Mohsen Izadi <mohsen@chromium.org> Date: Fri May 26 19:09:24 2017 Refactor SetupConnectedItem() in Ash system menu Added SetupConnectingScrollListItem() and SetupConnectedScrollListItem() to TrayDetailsView so that all connectivity detailed views can use it. BUG= 686924 TEST=none Change-Id: If0fd5a05df9d3db100e89c7b51ed36c759b5430e Reviewed-on: https://chromium-review.googlesource.com/514383 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by: Terry Anderson <tdanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#475080} [modify] https://crrev.com/33fcecd6c91552f374b30b153d7a914bd74d52e8/ash/system/bluetooth/tray_bluetooth.cc [modify] https://crrev.com/33fcecd6c91552f374b30b153d7a914bd74d52e8/ash/system/network/network_list.cc [modify] https://crrev.com/33fcecd6c91552f374b30b153d7a914bd74d52e8/ash/system/network/network_list.h [modify] https://crrev.com/33fcecd6c91552f374b30b153d7a914bd74d52e8/ash/system/network/vpn_list_view.cc [modify] https://crrev.com/33fcecd6c91552f374b30b153d7a914bd74d52e8/ash/system/network/vpn_list_view.h [modify] https://crrev.com/33fcecd6c91552f374b30b153d7a914bd74d52e8/ash/system/tray/tray_details_view.cc [modify] https://crrev.com/33fcecd6c91552f374b30b153d7a914bd74d52e8/ash/system/tray/tray_details_view.h
,
May 26 2017
,
Jul 28 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by tdander...@chromium.org
, Feb 7 2017