Kevin kernel can't build with SND_SOC_HDMI_CODEC=n |
||||
Issue descriptionWith this: diff --git a/chromeos/config/arm64/common.config b/chromeos/config/arm64/common.config index b87565986d23..09b4a590b4b8 100644 --- a/chromeos/config/arm64/common.config +++ b/chromeos/config/arm64/common.config @@ -826,7 +826,7 @@ CONFIG_RESET_CONTROLLER=y # CONFIG_RFD_FTL is not set # CONFIG_RFKILL_REGULATOR is not set CONFIG_ROCKCHIP_ANALOGIX_DP=y -CONFIG_ROCKCHIP_CDN_DP=y +# CONFIG_ROCKCHIP_CDN_DP is not set # CONFIG_ROCKCHIP_DW_HDMI is not set # CONFIG_ROCKCHIP_DW_MIPI_DSI is not set CONFIG_ROCKCHIP_EFUSE=y We then disable SND_SOC_HDMI_CODEC, and I see this build error: sound/built-in.o: In function `rockchip_sound_cdndp_init': /mnt/host/source/src/third_party/kernel/v4.4/sound/soc/rockchip/rk3399_gru_sound.c:283: undefined reference to `hdmi_codec_set_jack_detect' I think a simple Kconfig change will help this. Change coming shortly.
,
Jan 31 2017
I noticed that if I manage to successfully build without DP support, the kernel still defers probing the platform sound device indefinitely, because nobody loaded the HDMI/i2c-hifi codec: [ 34.562824] rk3399-gru-sound sound: ASoC: CODEC DAI i2s-hifi not registered So should it be a hard-depends, or should there be a way to boot w/o DP support?
,
Jan 31 2017
Some depends or select is wrong. Is i2s-hifi needed by some non-DP driver ? It must be referenced somewhere in devicetree.
,
Jan 31 2017
sound/soc/rockchip/rk3399_gru_sound.c:344: .codec_dai_name = "i2s-hifi", This sound driver apparently expects a particular set of codecs, and it will not load if it doesn't get all of them.
,
Jan 31 2017
#4: Looks like the Kconfig entry for rk3399_gru_sound should either depend on or select all the codecs it needs.
,
Jan 31 2017
It seems kinda dumb to require all or nothing though. But hey, I don't work on audio. BTW, for reference, this fixes the build errors: https://chromium-review.googlesource.com/c/434979/
,
Feb 1 2017
Gerrit's having problems communicating this here, but #6 was merged. That fixes the build errors, but there's still the runtime / probe-deferral problems when DP driver is missing. I won't worry about that for the moment.
,
Nov 7 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by briannorris@chromium.org
, Jan 30 2017