New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 686902 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task



Sign in to add a comment

Notifications too Small, Cuts Off Test

Project Member Reported by hennessywill@chromium.org, Jan 30 2017

Issue description

Chrome Version: 57.0.2987.17 dev
OS: CrOS

What steps will reproduce the problem?
(1) Open notifications menu
(2)
(3)

What is the expected result?
Notifications should be properly sized to fit all text

What happens instead?
Some text and images are cut off


attached screenshot and sys logs
 
notifications_cut_off.jpg
48.5 KB View Download
52436452982-system_logs.zip
1.2 MB Download
Cc: abodenha@chromium.org
Owner: osh...@chromium.org

Comment 2 by osh...@chromium.org, Jan 30 2017

What's the device and arc version? Cut&pasting all version info in chrome://version would be enough.
This is on our new Reef device

Google Chrome	57.0.2987.17 (Official Build) dev (64-bit)
Revision	0
Platform	9202.10.0 (Official Build) dev-channel reef
ARC	3652901
JavaScript	V8 5.7.492.22
Flash	24.0.0.207 /opt/google/chrome/pepper/libpepflashplayer.so
User Agent	Mozilla/5.0 (X11; CrOS x86_64 9202.10.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.17 Safari/537.36
Cc: elijahtaylor@chromium.org xiy...@chromium.org
Status: Assigned (was: Untriaged)
This is ARC++ notification. I'll look into this only for NYC. +elijahtaylor@ fyi.
N has a different notification min height. It is changed from 64dp to 92dp on trunk [1]. We should probably update out defaults in ArcNotificationsService [2]. yoshiki@ has changed it to 69dp, which is not enough.

The max height should be updated too. N is now using 284dp. We need to update both ArcNotificationsService and the constraints in CustomNotificationView in chrome [3] from 256dp to 284dp.

[1]: https://cs.corp.google.com/android/frameworks/base/packages/SystemUI/res/values/dimens.xml?rcl=0fcdf4399e86ea3fb905b1298915afec46fb3be6&l=70
[2]: https://googleplex-android.git.corp.google.com/platform/frameworks/base/+/nyc-mr1-arc/services/core/arc/com/android/server/ArcNotificationsService.java#219
[3]: https://cs.chromium.org/chromium/src/ui/message_center/views/custom_notification_view.cc?rcl=926bfbada832ec9bfdb0a007333317d3f6218a7f&l=84
Cc: yoshiki@chromium.org
Chrome has to run with both N and M android runtime. Do you think min/max use for N will work with M arc? Or we need to send this from android side?
Re #7: Good question. I think we can make it work for both N and M by making Chrome's min/max covers the union of N and M's range. That is, we should keep 64dp min and update max to 284dp. The notification surface is created on Android side so it would have correct/desired size. As long as Chrome's min/max is large enough to cover both ranges (i.e. 64-256 in M, 92-284 in N), the notification surface size would be used for the hosting view. 

Comment 9 by peter@chromium.org, Feb 3 2017

Components: UI>Notifications
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d22df64ee43d357a38a3e318aab72c0dddac1ec

commit 9d22df64ee43d357a38a3e318aab72c0dddac1ec
Author: oshima <oshima@chromium.org>
Date: Sat Feb 04 00:45:21 2017

Update min/max notification height for N

BUG= 686902 

Review-Url: https://codereview.chromium.org/2676473004
Cr-Commit-Position: refs/heads/master@{#448125}

[modify] https://crrev.com/9d22df64ee43d357a38a3e318aab72c0dddac1ec/ui/message_center/views/custom_notification_view.cc

Status: Fixed (was: Assigned)
Labels: -Type-Bug Type-Task
Thank you Oshima. Will these notifications appear in 57 when Android is disabled? If so, we should merge to reef 57 branch 9202.B

However if the notifications won't appear until N ships in 58, this is fine
I still this in the Reef branch (currently version 57.0.2987.46 dev )

Can we merge in to Reef?

Comment 14 by oshima@google.com, Feb 14 2017

These notifications are from Android, so this won't happen when Android is disabled.
Labels: VerifyIn-61

Comment 16 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment