New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 686899 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility

Blocking:
issue 643240



Sign in to add a comment

ChromeVox alert screen on/off bug for tablet power button

Project Member Reported by warx@chromium.org, Jan 30 2017

Issue description

Since  issue 646388 , there are now two bugs (or maybe they are the same).

Extracted from issue 643240, "Just reviewed accessibility and we're waiting on a bug that needs to be resolved. We added spoken feedback when the button is pressed to indicate if the screen is off or on (for non-visual users using ChromeVox). When testing, we just encountered a bug when you press the button to turn the screen off, where it has dual voices saying "screen off" in unison, and then ChromeVox continues to speak the pin unlock UI as if it was still on screen."

(1) The dual "screen off" no longer happens, tested on both latest m57 and tot. Instead, the first "alert screen off" is missing when switching from user screen to locked screen.

(2) chromevox will continue to speak the pin unlock UI as if it was still on screen.
 

Comment 1 by warx@chromium.org, Feb 1 2017

Cc: xiy...@chromium.org dtseng@chromium.org
One more bug found: On locked screen, start chromevox, then click top-left corner of chromevox, then press 'ESC' to return to locked screen. Tapping power button for turning display off will alert "alert screen off" for sequential two times and tapping power button for turning display on will alert "alert screen on" for sequential two times.

After discussing with dtseng@, one solution is "do not focus on lock screen when screen is off". After my investigation, the password line will still be chromevox focused even though it is not keyboard focused, which means it has an orange a11y box. So, chromevox will still speak "password edit text...."

I don't know why it happens. But it happens only when there is no orange box on logged-in user's screen. It seems if there is no current orange box, it will try to focus one. But I am still not quite clear of this.
This is because the webview hosting the locked screen/password text field still becomes active.

One potential solution is to annotate the accessibility node wrapping the aura window.

See
ui/views/accessibility/ax_window_obj_wrapper.cc::Serialize.

 there should be some way to know that the window is invisible. If we can convey that information to ChromeVox, we can ignore any events inside of "invisible" windows. With such an annotation available, I can handle silencing ChromeVox.

AX_STATE_INVISIBLE is the proposed state.

Comment 3 by warx@chromium.org, Feb 2 2017

Blocking: 643240
warx@ do you have any CLs ready yet?

Comment 5 by warx@chromium.org, Feb 2 2017

I have a CL that is not sending for review yet. I need to first chat with tbuckley about the change.
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38b110ec3981062d81c3e61a3a0508eee0f2f1c2

commit 38b110ec3981062d81c3e61a3a0508eee0f2f1c2
Author: warx <warx@chromium.org>
Date: Mon Feb 06 18:45:30 2017

ChromeVox: Disable following a11y events after screen off alert is received

BUG= 686899 
TEST=turning the screen off works fine. For turning the screen on, the "alert screen on" is missing if chromvox needs to talk back the screen focus for the first time.

Review-Url: https://codereview.chromium.org/2676563003
Cr-Commit-Position: refs/heads/master@{#448324}

[modify] https://crrev.com/38b110ec3981062d81c3e61a3a0508eee0f2f1c2/chrome/browser/ui/ash/chrome_shell_delegate.cc

Comment 7 by warx@chromium.org, Feb 6 2017

Labels: Merge-Request-57
Request merge to M-57, thanks!

Comment 8 by ketakid@google.com, Feb 6 2017

Labels: -Merge-Request-57 Merge-Approved-57
Approving merge to M57 Chrome OS.
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 7 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c6c221e6b72bcb4c38463fa22d5c8b0db0415f6

commit 6c6c221e6b72bcb4c38463fa22d5c8b0db0415f6
Author: Qiang Xu <warx@chromium.org>
Date: Tue Feb 07 00:32:09 2017

[Merge to M57] ChromeVox: Disable following a11y events after screen off alert is received

TBR=jamescook@chromium.org, dtseng@chromium.org
BUG= 686899 
TEST=turning the screen off works fine. For turning the screen on, the "alert screen on" is missing if chromvox needs to talk back the screen focus for the first time.

Review-Url: https://codereview.chromium.org/2676563003
Cr-Commit-Position: refs/heads/master@{#448324}
(cherry picked from commit 38b110ec3981062d81c3e61a3a0508eee0f2f1c2)

Review-Url: https://codereview.chromium.org/2679823002 .
Cr-Commit-Position: refs/branch-heads/2987@{#352}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/6c6c221e6b72bcb4c38463fa22d5c8b0db0415f6/chrome/browser/ui/ash/chrome_shell_delegate.cc

Comment 10 by warx@chromium.org, Feb 7 2017

Status: Fixed (was: Assigned)
Fix reporter's bug, another bug is tracked at issue 689123
Components: UI>Accessibility>ChromeVox
Cc: -xiy...@chromium.org xiy...@chromium.ofixedrg
Status: Verified (was: Fixed)

Sign in to add a comment