New issue
Advanced search Search tips

Issue 686890 link

Starred by 1 user
Status: Fixed
Owner:
mthiesse@chromium.org
Closed: Feb 2017
Cc:
bajones@chromium.org
mthiesse@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Proj-XR

Blocked on:
issue 686232


Sign in to add a comment

Reconnect the VRVSyncProvider to the focused page on focus

Project Member Reported by mthiesse@chromium.org, Jan 30 2017 
Right now the VRVSyncProvider connects to the most recently created VRDisplay. We need to know when a VRDisplay gains focus and reconnect it to the VSync provider.

This is half blocked on  issue 686232 , because currently we don't/can't know when the VRDisplay gains/loses focus due to app switching or multiwindow. However, we should be able to fix this for tab switching, or having many magic windows on one page.

Comment 1 by mthiesse@chromium.org, Jan 30 2017

Owner: mthiesse@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/527310a8c856c31a016c8f9c9ddb90a5290aef5b

commit 527310a8c856c31a016c8f9c9ddb90a5290aef5b
Author: mthiesse <mthiesse@chromium.org>
Date: Mon Feb 06 18:31:06 2017

Provide WebVR pose data only to the focused frame.

Testing is tracked in  issue 679827 . For now this is manually tested.

BUG= 683322 ,  686890 

Review-Url: https://codereview.chromium.org/2668003003
Cr-Commit-Position: refs/heads/master@{#448315}

[modify] https://crrev.com/527310a8c856c31a016c8f9c9ddb90a5290aef5b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/527310a8c856c31a016c8f9c9ddb90a5290aef5b/third_party/WebKit/Source/core/page/BUILD.gn
[add] https://crrev.com/527310a8c856c31a016c8f9c9ddb90a5290aef5b/third_party/WebKit/Source/core/page/FocusChangedObserver.cpp
[add] https://crrev.com/527310a8c856c31a016c8f9c9ddb90a5290aef5b/third_party/WebKit/Source/core/page/FocusChangedObserver.h
[modify] https://crrev.com/527310a8c856c31a016c8f9c9ddb90a5290aef5b/third_party/WebKit/Source/core/page/FocusController.cpp
[modify] https://crrev.com/527310a8c856c31a016c8f9c9ddb90a5290aef5b/third_party/WebKit/Source/core/page/FocusController.h
[modify] https://crrev.com/527310a8c856c31a016c8f9c9ddb90a5290aef5b/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp
[modify] https://crrev.com/527310a8c856c31a016c8f9c9ddb90a5290aef5b/third_party/WebKit/Source/modules/vr/NavigatorVR.h
[modify] https://crrev.com/527310a8c856c31a016c8f9c9ddb90a5290aef5b/third_party/WebKit/Source/modules/vr/VRController.cpp
[modify] https://crrev.com/527310a8c856c31a016c8f9c9ddb90a5290aef5b/third_party/WebKit/Source/modules/vr/VRController.h
[modify] https://crrev.com/527310a8c856c31a016c8f9c9ddb90a5290aef5b/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/527310a8c856c31a016c8f9c9ddb90a5290aef5b/third_party/WebKit/Source/modules/vr/VRDisplay.h

Comment 3 by mthiesse@chromium.org, Feb 6 2017

Status: Fixed (was: Available)

Comment 4 by meganlindsay@chromium.org, Feb 16 2017

Labels: Proj-VR

Comment 5 by btebbs@chromium.org, Jul 4

Components: Blink>WebXR
►

Sign in to add a comment