New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 686887 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Measure network data use of tab restore

Project Member Reported by bengr@chromium.org, Jan 30 2017

Issue description

When a tab is restored, the last page in the tab is reloaded without cache revalidation. We should measure how much data is used during restore. UMA that measures page load size on the navigation that restores the tab should suffice.
 
Cc: aposner@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/248635a7e9e48fdebb242b60e81c46e90fca35e7

commit 248635a7e9e48fdebb242b60e81c46e90fca35e7
Author: ryansturm <ryansturm@chromium.org>
Date: Wed Feb 22 14:39:52 2017

Adding TabRestore PLM UMA

Adds bytes used UMA for TabRestores. There will be follow-up CLs to add
various other UMA to this observer and CorePageLoadMetricsObserver.

TabRestores here only include the first navigation entry after a tab
restore (forward-back navigations that were restored are excluded). The
goal is to evaluate how expensive TabRestores are for data sensitive
users.

BUG= 686887 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2694183004
Cr-Commit-Position: refs/heads/master@{#452041}

[modify] https://crrev.com/248635a7e9e48fdebb242b60e81c46e90fca35e7/chrome/browser/BUILD.gn
[add] https://crrev.com/248635a7e9e48fdebb242b60e81c46e90fca35e7/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer.cc
[add] https://crrev.com/248635a7e9e48fdebb242b60e81c46e90fca35e7/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer.h
[add] https://crrev.com/248635a7e9e48fdebb242b60e81c46e90fca35e7/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/248635a7e9e48fdebb242b60e81c46e90fca35e7/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
[modify] https://crrev.com/248635a7e9e48fdebb242b60e81c46e90fca35e7/chrome/test/BUILD.gn
[modify] https://crrev.com/248635a7e9e48fdebb242b60e81c46e90fca35e7/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/248635a7e9e48fdebb242b60e81c46e90fca35e7/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/248635a7e9e48fdebb242b60e81c46e90fca35e7/content/public/browser/navigation_handle.h
[modify] https://crrev.com/248635a7e9e48fdebb242b60e81c46e90fca35e7/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)
 Issue 662471  has been merged into this issue.

Sign in to add a comment