New issue
Advanced search Search tips

Issue 686876 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[REGRESSION] DevTools: empty TextPrompt has different height

Project Member Reported by dgozman@chromium.org, Jan 30 2017

Issue description

1. Open Elements panel.
2. Add new CSS property.
3. Type 'w' in property name prompt.

Observe the height change and layout jumping.
 
Labels: ReleaseBlock-Stable
Let's bisect - we'll probably need to merge it.
Labels: -Type-Bug Type-Bug-Regression
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe93dfadae6424df9875c7e9f72b27985ba7d6d1

commit fe93dfadae6424df9875c7e9f72b27985ba7d6d1
Author: einbinder <einbinder@chromium.org>
Date: Tue Feb 07 00:10:59 2017

DevTools: Always have some content in a TextPrompt

If the TextPrompt was empty, it migh t have a different height then when
the first character is typed. This patch adds a psuedoelement with a
single character so that the height remains constant.

BUG= 686876 

Review-Url: https://codereview.chromium.org/2678183002
Cr-Commit-Position: refs/heads/master@{#448456}

[modify] https://crrev.com/fe93dfadae6424df9875c7e9f72b27985ba7d6d1/third_party/WebKit/Source/devtools/front_end/ui/textPrompt.css

Labels: -ReleaseBlock-Stable
Status: Fixed (was: Assigned)

Sign in to add a comment