New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 686870 link

Starred by 2 users
Status: Verified
Owner:
mattreynolds@chromium.org
Closed: Feb 2017
Cc:
█ mmo...@chromium.org
█ animohan@chromium.org
█ scottj@chromium.org
ios-bugs@chromium.org
█ cco3@chromium.org
mattreynolds@chromium.org
█ rzhao@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[iOS] Remove logo from Physical Web omnibox suggestions

Project Member Reported by mattreynolds@chromium.org, Jan 30 2017 
On iOS, tapping the Physical Web logo displayed in PW omnibox suggestions navigates to the Physical Web privacy preferences page.  Let's make the logo behave the same as the rest of the omnibox row (ie, it should open the suggested URL).
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb78c99e38bdd1c36d8e1b0b4239c303cf62c8ec

commit eb78c99e38bdd1c36d8e1b0b4239c303cf62c8ec
Author: mattreynolds <mattreynolds@chromium.org>
Date: Mon Feb 06 19:03:59 2017

Remove logo from Physical Web omnibox suggestions

Previously, Physical Web suggestions displayed a logo image at the end of
the suggestion row. With this change, the logo is removed. Single-URL
Physical Web suggestions will display the append-into-edit arrow button.
Grouped suggestions will display no icon.

BUG= 686870 

Review-Url: https://codereview.chromium.org/2674543002
Cr-Commit-Position: refs/heads/master@{#448331}

[modify] https://crrev.com/eb78c99e38bdd1c36d8e1b0b4239c303cf62c8ec/ios/chrome/app/main_controller.mm
[delete] https://crrev.com/b8d63f435e6c869164a0ec63eec5be867d2b7157/ios/chrome/app/theme/default_100_percent/omnibox/physical_web_highlighted_ios.png
[delete] https://crrev.com/b8d63f435e6c869164a0ec63eec5be867d2b7157/ios/chrome/app/theme/default_100_percent/omnibox/physical_web_ios.png
[delete] https://crrev.com/b8d63f435e6c869164a0ec63eec5be867d2b7157/ios/chrome/app/theme/default_200_percent/omnibox/physical_web_highlighted_ios.png
[delete] https://crrev.com/b8d63f435e6c869164a0ec63eec5be867d2b7157/ios/chrome/app/theme/default_200_percent/omnibox/physical_web_ios.png
[delete] https://crrev.com/b8d63f435e6c869164a0ec63eec5be867d2b7157/ios/chrome/app/theme/default_300_percent/omnibox/physical_web_highlighted_ios.png
[delete] https://crrev.com/b8d63f435e6c869164a0ec63eec5be867d2b7157/ios/chrome/app/theme/default_300_percent/omnibox/physical_web_ios.png
[modify] https://crrev.com/eb78c99e38bdd1c36d8e1b0b4239c303cf62c8ec/ios/chrome/app/theme/ios_theme_resources.grd
[modify] https://crrev.com/eb78c99e38bdd1c36d8e1b0b4239c303cf62c8ec/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/eb78c99e38bdd1c36d8e1b0b4239c303cf62c8ec/ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.h
[modify] https://crrev.com/eb78c99e38bdd1c36d8e1b0b4239c303cf62c8ec/ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.mm
[modify] https://crrev.com/eb78c99e38bdd1c36d8e1b0b4239c303cf62c8ec/ios/chrome/browser/ui/omnibox/omnibox_popup_material_view_controller.mm
[modify] https://crrev.com/eb78c99e38bdd1c36d8e1b0b4239c303cf62c8ec/ios/chrome/browser/ui/settings/settings_navigation_controller.h
[modify] https://crrev.com/eb78c99e38bdd1c36d8e1b0b4239c303cf62c8ec/ios/chrome/browser/ui/settings/settings_navigation_controller.mm

Comment 2 by mattreynolds@chromium.org, Feb 7 2017

Labels: Merge-Request-57
Summary: [iOS] Remove logo from Physical Web omnibox suggestions (was: [iOS] Remove omnibox link to Physical Web privacy preferences)
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 7 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 10 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93ce0f4d2334a313c678968992bad1e174f7859b

commit 93ce0f4d2334a313c678968992bad1e174f7859b
Author: mattreynolds <mattreynolds@chromium.org>
Date: Fri Feb 10 21:06:26 2017

Remove logo from Physical Web omnibox suggestions

Previously, Physical Web suggestions displayed a logo image at the end of
the suggestion row. With this change, the logo is removed. Single-URL
Physical Web suggestions will display the append-into-edit arrow button.
Grouped suggestions will display no icon.

BUG= 686870 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2674543002
Cr-Commit-Position: refs/heads/master@{#448331}
(cherry picked from commit eb78c99e38bdd1c36d8e1b0b4239c303cf62c8ec)

Review-Url: https://codereview.chromium.org/2693543002
Cr-Commit-Position: refs/branch-heads/2987@{#451}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/93ce0f4d2334a313c678968992bad1e174f7859b/ios/chrome/app/main_controller.mm
[delete] https://crrev.com/e5010a4817336dfc3290463c114a2691352d5466/ios/chrome/app/theme/default_100_percent/omnibox/physical_web_highlighted_ios.png
[delete] https://crrev.com/e5010a4817336dfc3290463c114a2691352d5466/ios/chrome/app/theme/default_100_percent/omnibox/physical_web_ios.png
[delete] https://crrev.com/e5010a4817336dfc3290463c114a2691352d5466/ios/chrome/app/theme/default_200_percent/omnibox/physical_web_highlighted_ios.png
[delete] https://crrev.com/e5010a4817336dfc3290463c114a2691352d5466/ios/chrome/app/theme/default_200_percent/omnibox/physical_web_ios.png
[delete] https://crrev.com/e5010a4817336dfc3290463c114a2691352d5466/ios/chrome/app/theme/default_300_percent/omnibox/physical_web_highlighted_ios.png
[delete] https://crrev.com/e5010a4817336dfc3290463c114a2691352d5466/ios/chrome/app/theme/default_300_percent/omnibox/physical_web_ios.png
[modify] https://crrev.com/93ce0f4d2334a313c678968992bad1e174f7859b/ios/chrome/app/theme/ios_theme_resources.grd
[modify] https://crrev.com/93ce0f4d2334a313c678968992bad1e174f7859b/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/93ce0f4d2334a313c678968992bad1e174f7859b/ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.h
[modify] https://crrev.com/93ce0f4d2334a313c678968992bad1e174f7859b/ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.mm
[modify] https://crrev.com/93ce0f4d2334a313c678968992bad1e174f7859b/ios/chrome/browser/ui/omnibox/omnibox_popup_material_view_controller.mm
[modify] https://crrev.com/93ce0f4d2334a313c678968992bad1e174f7859b/ios/chrome/browser/ui/settings/settings_navigation_controller.h
[modify] https://crrev.com/93ce0f4d2334a313c678968992bad1e174f7859b/ios/chrome/browser/ui/settings/settings_navigation_controller.mm

Comment 5 by mattreynolds@chromium.org, Feb 10 2017

Status: Fixed (was: Started)

Comment 6 by vkarut...@chromium.org, Feb 14 2017

Status: Verified (was: Fixed)
Verified in 58.0.3012.0, iPhone7 plus iOS 10.2.1

Comment 7 Deleted

Comment 8 by vbhatso...@chromium.org, Mar 2 2017 

https://drive.google.com/open?id=0B6GVWQnhaMCleUxMcW9fcmQ2VjQ
Verified on 57.0.2987.88 Beta(PW is 100%) on iPhone 7 iOS 10.1.1 and iPad Air iOS 10.1.1
►

Sign in to add a comment