Display settings page working in mustash |
|||||
Issue descriptionThe display settings page, which is basically DisplayOptionsHandler, is going to be part of the chrome process (at least for now). DisplayOptionsHandler reaches into DisplayConfigurationController DisplayManager to get the current display state and make display configuration changes. This won't work for mustash as DisplayManager is in a different process. Here are some rough steps to make DisplayOptionsHandler work with mustash: 1. Make DisplayConfigurationController into an interface to get screen state and make configuration changes. 2. Modify DisplayOptionsHandler to only talk to DisplayConfigurationController and to work asynchronously. 3. Classic ash version of DisplayConfigurationController doesn't change much. Add methods where necessary to get screen state. 4. Add to Mojo interface mojom::ScreenManager as necessary. Add mustash version of DisplayConfigurationController that uses mojom::ScreenManager interface.
,
Jan 31 2017
Sounds good to me. It might be good to get some work on this started in Q1 because it's a complicated task, but otherwise it's unnecessary for the 30 minute browsing OKR.
,
Feb 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d6d5d29921ee1e7cc9c6ce11187bc8ccb11d8f3 commit 1d6d5d29921ee1e7cc9c6ce11187bc8ccb11d8f3 Author: kylechar <kylechar@chromium.org> Date: Fri Feb 03 14:34:49 2017 Add DisplayPlacement/Layout mojoms + StructTraits. Add mojoms and StructTraits so that a complete DisplayLayout can be serialized. This includes DisplayPlacement and some enums. DisplayLayout is serialized via unique_ptr since it is normally stored as a unique_ptr. This is required to pass the DisplayLayout from mus-ws to chrome for the display options page. BUG= 686848 Review-Url: https://codereview.chromium.org/2661663002 Cr-Commit-Position: refs/heads/master@{#447990} [modify] https://crrev.com/1d6d5d29921ee1e7cc9c6ce11187bc8ccb11d8f3/ui/display/display_layout.cc [modify] https://crrev.com/1d6d5d29921ee1e7cc9c6ce11187bc8ccb11d8f3/ui/display/display_layout.h [modify] https://crrev.com/1d6d5d29921ee1e7cc9c6ce11187bc8ccb11d8f3/ui/display/mojo/BUILD.gn [add] https://crrev.com/1d6d5d29921ee1e7cc9c6ce11187bc8ccb11d8f3/ui/display/mojo/display_layout.mojom [add] https://crrev.com/1d6d5d29921ee1e7cc9c6ce11187bc8ccb11d8f3/ui/display/mojo/display_layout.typemap [add] https://crrev.com/1d6d5d29921ee1e7cc9c6ce11187bc8ccb11d8f3/ui/display/mojo/display_layout_struct_traits.cc [add] https://crrev.com/1d6d5d29921ee1e7cc9c6ce11187bc8ccb11d8f3/ui/display/mojo/display_layout_struct_traits.h [modify] https://crrev.com/1d6d5d29921ee1e7cc9c6ce11187bc8ccb11d8f3/ui/display/mojo/display_struct_traits.cc [modify] https://crrev.com/1d6d5d29921ee1e7cc9c6ce11187bc8ccb11d8f3/ui/display/mojo/display_struct_traits_test.mojom [modify] https://crrev.com/1d6d5d29921ee1e7cc9c6ce11187bc8ccb11d8f3/ui/display/mojo/display_struct_traits_unittest.cc [modify] https://crrev.com/1d6d5d29921ee1e7cc9c6ce11187bc8ccb11d8f3/ui/display/mojo/typemaps.gni
,
Feb 8 2017
,
Mar 27 2017
,
Mar 16 2018
The work described here isn't relevant anymore as DisplayOptionsHandler was removed. Settings works through an extension API now.
,
Mar 20 2018
Hey Steven, here's the old bug I mentioned.
,
Mar 20 2018
We do need to fix the extension API though :) I will open a separate bug to track that.
,
Mar 20 2018
I morphed Issue 682402 into that. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sky@chromium.org
, Jan 31 2017