Clang static useful analysis tracking bug |
||
Issue descriptionThis bug is for tracking CLs or bugs that were successfully identified or resolved as a result of Clang static analyzer's warnings.
,
Feb 8 2017
This was a very minor issue. https://codereview.chromium.org/2683583006/ Message: ../../components/ntp_tiles/most_visited_sites.cc:196:7: warning: Value stored to 'num_tiles' is never read num_tiles = i; Unfortunately, all remaining messages were not helpful (see issue 686829 ).
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/468141a302bc1a593c5f9ec5286e858cf3a5f465 commit 468141a302bc1a593c5f9ec5286e858cf3a5f465 Author: kmarshall <kmarshall@chromium.org> Date: Thu Feb 09 20:24:38 2017 Fix loop early exit bug in blockfile cache Trim behavior. This bug fixes an issue in which a "done" bool in a loop is never set since it is reinitialized at the top of the loop body. (Detected as a dead store by the Clang static analyzer.) R=wez@chromium.org,msramek@chromium.org BUG= 686838 Review-Url: https://codereview.chromium.org/2673863003 Cr-Commit-Position: refs/heads/master@{#449392} [modify] https://crrev.com/468141a302bc1a593c5f9ec5286e858cf3a5f465/net/disk_cache/blockfile/eviction.cc
,
Feb 14 2017
It looks like the analyzer is finding cases where possible bad memory accesses may occur in structs with pointer fields that lack initializers.
e.g. the field "name" in base::Feature is not initialized to nullptr, and the field is not DCHECK'd for non-nullness.
Hence this warning:
../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/locale_facets.tcc:1258:9: warning: Assigned value is garbage or undefined
*__s++ = *__first++;
^
../../base/metrics/field_trial_params.cc:106:3: note: Taking false branch
if (value_as_string == "true")
^
../../base/metrics/field_trial_params.cc:108:3: note: Taking false branch
if (value_as_string == "false")
^
../../base/metrics/field_trial_params.cc:111:7: note: Assuming the condition is true
if (!value_as_string.empty()) {
^~~~~~~~~~~~~~~~~~~~~~~~
../../base/metrics/field_trial_params.cc:111:3: note: Taking true branch
if (!value_as_string.empty()) {
^
../../base/metrics/field_trial_params.cc:112:5: note: Assuming the condition is false
DLOG(WARNING) << "Failed to parse field trial param " << param_name
^~~~~~~~~~~~~
,
Feb 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13781f5c8e8f44939079dd8fd9ccfc14ba70048e commit 13781f5c8e8f44939079dd8fd9ccfc14ba70048e Author: stkhapugin <stkhapugin@chromium.org> Date: Mon Feb 20 15:25:54 2017 Fixes a memory leak in bookmarks detected with static analyzer. BUG= 686838 Review-Url: https://codereview.chromium.org/2702273002 Cr-Commit-Position: refs/heads/master@{#451628} [modify] https://crrev.com/13781f5c8e8f44939079dd8fd9ccfc14ba70048e/ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm
,
Jun 9 2017
Issue isn't actionable, so I'm archiving this bug. It still can be used for future fix CLs, though. |
||
►
Sign in to add a comment |
||
Comment 1 by kmarshall@chromium.org
, Jan 30 2017Status: Assigned (was: Untriaged)