New issue
Advanced search Search tips

Issue 686837 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 548429
issue 731255



Sign in to add a comment

Get mouse warp between displays working in mus

Project Member Reported by kylec...@chromium.org, Jan 30 2017

Issue description

For Ozone DRM with 2+ displays we need to move the mouse from one display to the other when we get to the relevant edge of the screen.

In classic ash there is mouse warp controller code in ash/display/. We need to add similar to code to the mus-ws for mustash. There are enough differences that it's not worth trying to use the same code for mustash and classic ash.
 
Components: Internals>GPU>Internals
Labels: Proj-Mustash-Milestone-Tadpole
Status: Available (was: Untriaged)
If the PlatformScreen is in DIP (it is right...) then this should not be too complicated.

Comment 2 by sky@chromium.org, Mar 27 2017

Labels: mustash-2
Labels: -mustash-display Proj-Ozone
Summary: Get mouse warp between displays working in mus (was: Get mouse warp between displays working in mustash)
Needed for mushrome.

Components: -Internals>GPU>Internals Internals>MUS
Labels: -Pri-3 Pri-2
Labels: mustash-display

Comment 6 by sky@chromium.org, Jun 8 2017

Blocking: 731255

Comment 7 by sky@chromium.org, Jul 19 2017

Owner: sky@chromium.org
Status: Started (was: Available)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f6eec5009c3813a93f3e9b40ec9c47d92c45181

commit 0f6eec5009c3813a93f3e9b40ec9c47d92c45181
Author: Scott Violet <sky@chromium.org>
Date: Tue Jul 25 16:47:23 2017

chromeos: gets mouse warping working for mus

Currently mouse warping in mus did not work because it early outs if
the event does not have a NativeEvent. In mus there is no NativeEvent,
hence warping not working. This change add a NativeEvent for the cases
we care about

BUG= 686837 
TEST=none

Change-Id: I33d59a26b4ed8e3abe06e12ebff45e9a9f2cadf0
Reviewed-on: https://chromium-review.googlesource.com/580076
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489340}
[modify] https://crrev.com/0f6eec5009c3813a93f3e9b40ec9c47d92c45181/ash/display/extended_mouse_warp_controller.h
[modify] https://crrev.com/0f6eec5009c3813a93f3e9b40ec9c47d92c45181/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/0f6eec5009c3813a93f3e9b40ec9c47d92c45181/ui/aura/mus/window_tree_client_unittest.cc

Comment 9 by sky@chromium.org, Jul 25 2017

Status: Fixed (was: Started)

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment