Issue metadata
Sign in to add a comment
|
Load and save display preferences in mustash |
||||||||||||||||||||||||
Issue descriptionWe need to load and save display preferences in mustash. The preferences are things like screen layout, extended/mirrored/unified mode and display resolution, color profile, overscan bounds, etc. On startup the display preferences are loaded. When screen state changes the new preferences are saved again. The preference loading/saving code is in chrome right now. The display management code in mus-ws. The preference loading code directly accesses DisplayManager. It will probably be easiest to move the preference loading/saving code and have as part of mus-ws. The code can use the preference service to access preferences in chrome.
,
Feb 13 2017
In the mustash world Chrome still maintains the loading and saving of preferences. Other services, such as Ash, are accessing/modifying these values via a preference mojom. Why do we believe that we need to move the pref loading/saving code to be a part of mus-ws? As a foresight note: another team is working on the long task of pull all of the preference code out of chrome, into its own standalone service.
,
Feb 13 2017
The display preference code takes in display::DisplayManager + display::DisplayConfigurator for the display state. For mustash, this state is located in the mus-ws process. That state is processed into JSON and then we have string preferences. The opposite happens for loading preferences, JSON is parsed and display state is set in DisplayManager + DisplayConfigurator. If I understand how the preference service works correctly (which I might not then) it would happen something the following. Loading: (1) Chrome loads the display preference strings (from a file somewhere?) (2) mus-ws gets preference strings from Chrome via IPC. (3) mus-ws parses the JSON and sets display state. Saving: (1) mus-ws builds JSON from display state. (2) mus-ws sends preference string to Chrome via IPC. (3) Chrome saves the display preferences.
,
Feb 13 2017
Ah so you were referring to how DisplayManager/DisplayConfigurator handle it. Your understanding of how the preference service works is correct. Is this sufficient for mus-ws?
,
Mar 27 2017
,
Apr 3 2017
,
Feb 26 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by rjkroege@chromium.org
, Jan 30 2017Labels: Proj-Mustash-Milestone-Tadpole
Status: Available (was: Untriaged)