New issue
Advanced search Search tips

Issue 686835 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 678949
Owner: ----
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 548429



Sign in to add a comment

Load and save display preferences in mustash

Project Member Reported by kylec...@chromium.org, Jan 30 2017

Issue description

We need to load and save display preferences in mustash. The preferences are things like screen layout, extended/mirrored/unified mode and display resolution, color profile, overscan bounds, etc.

On startup the display preferences are loaded. When screen state changes the new preferences are saved again.

The preference loading/saving code is in chrome right now. The display management code in mus-ws. The preference loading code directly accesses DisplayManager. 

It will probably be easiest to move the preference loading/saving code and have as part of mus-ws. The code can use the preference service to access preferences in chrome.
 
Components: Internals>MUS
Labels: Proj-Mustash-Milestone-Tadpole
Status: Available (was: Untriaged)
My presumption is that this needs to be written against the file service.
In the mustash world Chrome still maintains the loading and saving of preferences.

Other services, such as Ash, are accessing/modifying these values via a preference mojom.

Why do we believe that we need to move the pref loading/saving code to be a part of mus-ws?

As a foresight note: another team is working on the long task of pull all of the preference code out of chrome, into its own standalone service.
The display preference code takes in display::DisplayManager + display::DisplayConfigurator for the display state. For mustash, this state is located in the mus-ws process. That state is processed into JSON and then we have string preferences. The opposite happens for loading preferences, JSON is parsed and display state is set in DisplayManager + DisplayConfigurator.

If I understand how the preference service works correctly (which I might not then) it would happen something the following.

Loading:
(1) Chrome loads the display preference strings (from a file somewhere?)
(2) mus-ws gets preference strings from Chrome via IPC.
(3) mus-ws parses the JSON and sets display state.

Saving:
(1) mus-ws builds JSON from display state.
(2) mus-ws sends preference string to Chrome via IPC.
(3) Chrome saves the display preferences.
Ah so you were referring to how DisplayManager/DisplayConfigurator handle it.

Your understanding of how the preference service works is correct. Is this sufficient for mus-ws?

Comment 5 by sky@chromium.org, Mar 27 2017

Labels: mustsah-2
Mergedinto: 678949
Status: Duplicate (was: Available)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment