New issue
Advanced search Search tips

Issue 686833 link

Starred by 0 users
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Jan 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Allocate more resources for options_resources.grd structures.

Project Member Reported by sammiequon@chromium.org, Jan 30 2017 
Adding a new structure to options_resources.grd will cause WebUIResourceBrowserTest.* to fail with error [30658:30658:0126/153131.006577:FATAL:data_pack.cc(246)] Check failed: !handle->HasResource(resource_id). Duplicate resource 11950 with scale 1.

This may be because options_resources.grd is allocated 30 spots for structures and there are currently 30 structures in options_resources.grd.

Update tools/gritsettings/resource_ids so that options_resources.grd has more resources allocated.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d523103ef65af1e0cc514af41e2e26e2747e5f97

commit d523103ef65af1e0cc514af41e2e26e2747e5f97
Author: sammiequon <sammiequon@chromium.org>
Date: Tue Jan 31 00:37:59 2017

Add 20 resources for options_resources.grd.

Cannot add new structures to options_resources.grd at the moment due to there being allocated 30 resources and options_resources.grd already has 30 resources.

BUG= 686833 
TEST=none

Review-Url: https://codereview.chromium.org/2661983002
Cr-Commit-Position: refs/heads/master@{#447134}

[modify] https://crrev.com/d523103ef65af1e0cc514af41e2e26e2747e5f97/tools/gritsettings/resource_ids

Comment 2 by sammiequon@chromium.org, Jan 31 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment