New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 686832 link

Starred by 1 user
Status: Verified
Owner:
█ imch...@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Cc:
█ tuanav@chromium.org
dbbrooks@chromium.org
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Media Router Component extension not getting loaded with Chrome canary

Project Member Reported by dbbrooks@chromium.org, Jan 30 2017 
Chrome: 58.0.2997.0
OS: Win, Mac
MR: 5717.0130.0.0

What steps will reproduce the problem?
(1) Update to Chrome canary
(2) On a network with Chromecast receivers, open the Media Router dialog.

What is the expected result?
Chromecast devices listed

What happens instead?
No devices are listed. Clicking on "Report an issue" in the MR menu does not open the send feedback page, and its the same for the  "Manage cast devices" link.

This works fine on the current Chrome dev with the same MR extension. 57.0.2987.13

The load-media-router-component-extension flag was set to default. Enabling it made no difference, nor disabling it and re-enabling it.

Comment 1 by sko...@chromium.org, Jan 30 2017

Labels: -Pri-3 ReleaseBlock-Beta Pri-1

Comment 2 by sko...@chromium.org, Jan 30 2017

Status: Available (was: Untriaged)

Comment 3 by imch...@chromium.org, Jan 30 2017

Owner: imch...@chromium.org
Status: Started (was: Available)
Note: Related to https://bugs.chromium.org/p/chromium/issues/detail?id=686836. The extension fails to load due to missing dependency on origin.mojom when loading the MR extension. I am testing out a fix right now.

Comment 4 by imch...@chromium.org, Jan 30 2017 

It turns out we did not change the code in media_router_bindings.js to use Origin. So that needs to be fixed as well.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fcb4ac004446e6babe35d1d50adaa385280c770

commit 7fcb4ac004446e6babe35d1d50adaa385280c770
Author: imcheng <imcheng@chromium.org>
Date: Mon Jan 30 22:56:54 2017

Manual Revert of Convert MediaRouter mojom apis to intake url::Origin objects instead of strings (patchset #10 id:180001 of https://codereview.chromium.org/2627463003/ )

Reason for revert:
This broke Media Router:

1) Missing dependency on url/mojo/origin.mojom in extension's context (see https://codereview.chromium.org/2665853002/ for fix)

2) media_router_bindings.js and the extension code were not converted to use Origin objects.

Original issue's description:
> Convert MediaRouter mojom apis to intake url::Origin objects instead of strings
>
> Currently, MediaRouter passes origins around as strings in the mojom api, and as GURLs at a higher level. This CL changes both the strings and the GURLs to be url::Origins instead.
>
> BUG= 629374 
>
> Review-Url: https://codereview.chromium.org/2627463003
> Cr-Commit-Position: refs/heads/master@{#446868}
> Committed: https://chromium.googlesource.com/chromium/src/+/588ccce1960c1ca47d65c75f5edb34e5e17d6deb

TBR=mfoltz@chromium.org,dcheng@chromium.org,jdufault@chromium.org,wez@chromium.org,sky@chromium.org,steimel@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 629374 ,  686832 , 686836

Review-Url: https://codereview.chromium.org/2666743002
Cr-Commit-Position: refs/heads/master@{#447099}

[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/android/router/media_router_android.h
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/android/router/media_router_dialog_controller_android.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/BUILD.gn
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/create_presentation_connection_request.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/create_presentation_connection_request.h
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/create_presentation_connection_request_unittest.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/media_router.h
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/media_router_dialog_controller_unittest.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/media_sinks_observer.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/media_sinks_observer.h
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/media_sinks_observer_unittest.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/mock_media_router.h
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/mojo/media_router.mojom
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/mojo/media_router_mojo_test.h
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/presentation_media_sinks_observer.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/presentation_media_sinks_observer.h
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/presentation_request.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/presentation_request.h
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/presentation_request_unittest.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/presentation_service_delegate_impl.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/test_helper.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/test_helper.h
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/ui/ash/cast_config_client_media_router.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/ui/webui/media_router/media_router_ui.h
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/ui/webui/media_router/query_result_manager.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/ui/webui/media_router/query_result_manager.h
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/ui/webui/media_router/query_result_manager_unittest.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/test/media_router/media_router_e2e_browsertest.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/test/media_router/media_router_e2e_browsertest.h
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/test/media_router/test_media_sinks_observer.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/test/media_router/test_media_sinks_observer.h

Comment 6 by imch...@chromium.org, Jan 30 2017

Cc: dbbrooks@chromium.org
Status: Fixed (was: Started)
Just tested with Chromium built from head. David could you verify when it makes it to canary?

Comment 7 by dbbrooks@chromium.org, Feb 6 2017

Status: Verified (was: Fixed)
verified with 58.0.3004.0
►

Sign in to add a comment