New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 686794 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

ClangToT bots failing with "error: non-const static data member must be initialized out of line"

Project Member Reported by h...@chromium.org, Jan 30 2017

Issue description

Example from https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan/builds/6245/steps/compile/logs/stdio below

But it seems to be hitting most bots, at least Android and Windows.



FAILED: obj/third_party/angle/libANGLE/formatutils.o 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/angle/libANGLE/formatutils.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DNO_TCMALLOC -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DADDRESS_SANITIZER -DLEAK_SANITIZER -DWTF_USE_LEAK_SANITIZER=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=293472 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGL_GLEXT_PROTOTYPES -DEGL_EGLEXT_PROTOTYPES -DANGLE_ENABLE_OPENGL -DANGLE_USE_X11 -DANGLE_ENABLE_NULL -DLIBANGLE_IMPLEMENTATION -I../../third_party/angle/src/third_party/khronos -Igen/angle -I../../third_party/angle/include -I../../third_party/angle/src -I../../third_party/angle/src/common/third_party/numerics -I../../third_party/angle/include -I../../third_party/angle/src -I../../third_party/angle/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -fdebug-prefix-map=/b/c/b/ClangToTLinuxASan/src=. -m64 -march=x86-64 -pthread -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g1 --sysroot=../../build/linux/debian_wheezy_amd64-sysroot -gline-tables-only -gcolumn-info -fno-omit-frame-pointer -fsanitize=address -fsanitize-address-use-after-scope -fsanitize-blacklist=../../tools/memory/asan/blacklist.txt -fsanitize=leak -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -fno-exceptions -c ../../third_party/angle/src/libANGLE/formatutils.cpp -o obj/third_party/angle/libANGLE/formatutils.o
In file included from ../../third_party/angle/src/libANGLE/formatutils.cpp:11:
In file included from ../../third_party/angle/src/common/mathutil.h:19:
In file included from ../../third_party/angle/src/common/third_party/numerics/base/numerics/safe_math.h:14:
../../third_party/angle/src/common/third_party/numerics/base/numerics/safe_math_impl.h:107:9: error: non-const static data member must be initialized out of line
        value = CHAR_BIT * sizeof(Integer) - 1;
        ^       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/angle/src/common/third_party/numerics/base/numerics/safe_math_impl.h:138:15: note: in instantiation of template class 'base::internal::PositionOfSignBit<unsigned int>' requested here
              PositionOfSignBit<T>::value);
              ^
../../third_party/angle/src/common/third_party/numerics/base/numerics/safe_math_impl.h:196:13: note: in instantiation of function template specialization 'base::internal::HasSignBit<unsigned int>' requested here
        if (HasSignBit(BinaryComplement(static_cast<UnsignedDst>((uresult ^ ux) & (ux ^ uy)))))
            ^
../../third_party/angle/src/common/third_party/numerics/base/numerics/safe_math.h:311:1: note: in instantiation of function template specialization 'base::internal::CheckedSub<unsigned int>' requested here
BASE_NUMERIC_ARITHMETIC_OPERATORS(Sub, -, -=)
^
../../third_party/angle/src/common/third_party/numerics/base/numerics/safe_math.h:262:28: note: expanded from macro 'BASE_NUMERIC_ARITHMETIC_OPERATORS'
            static_cast<T>(Checked##NAME(static_cast<Promotion>(lhs.ValueUnsafe()),                \
                           ^
<scratch space>:295:1: note: expanded from here
CheckedSub
^
../../third_party/angle/src/common/mathutil.h:792:35: note: in instantiation of function template specialization 'base::internal::operator-<unsigned int>' requested here
    auto temp = value + alignment - static_cast<T>(1);
                                  ^
../../third_party/angle/src/libANGLE/formatutils.cpp:759:24: note: in instantiation of function template specialization 'rx::roundUp<base::internal::CheckedNumeric<unsigned int> >' requested here
    auto aligned = rx::roundUp(checkedRowBytes, checkedAlignment);
                       ^
 

Comment 1 by h...@chromium.org, Jan 30 2017

Cc: sammccall@google.com
Status: WontFix (was: Assigned)
This change is in range:

------------------------------------------------------------------------
r293455 | rsmith | 2017-01-29 20:38:28 -0800 (Sun, 29 Jan 2017) | 2 lines

Towards P0091R3: parsing support for class template argument deduction in typena
me-specifiers.
------------------------------------------------------------------------

And looks like it was already reverted in r293473 this morning, for what seems to be the same reason.

Sign in to add a comment