New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 686792 link

Starred by 5 users
Status: Fixed
Owner:
fmalita@chromium.org
Closed: Feb 2017
Cc:
yoichio@chromium.org
█ le...@chromium.org
rouslan@chromium.org
bsep@chromium.org
yosin@chromium.org
█ groby@chromium.org
schenney@chromium.org
malaykeshav@chromium.org
osh...@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Spellcheck error indicator not scale well on hidpi devices.

Reported by lxy.lixi...@gmail.com, Jan 30 2017 
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.76 Safari/537.36

Example URL:

Steps to reproduce the problem:
1. Open a page contains a text field.
2. Type something with typo.
3. See the result.

What is the expected behavior?

What went wrong?
It should scale as well as other content.

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 56.0.2924.76  Channel: stable
OS Version: 
Flash Version: Shockwave Flash 24.0 r0
Screenshot from 2017-01-31 01-22-47.png
4.2 KB View Download

Comment 1 by ligim...@chromium.org, Jan 30 2017

Labels: Prestable-56.0.2924.76 Needs-Triage-M56

Comment 2 by tkent@chromium.org, Jan 30 2017

Components: -Blink Blink>Editing>Spellcheck Blink>Paint UI>HighDPI

Comment 3 by schenney@chromium.org, Jan 31 2017

Cc: schenney@chromium.org
Labels: -OS-Linux OS-All
Status: Available (was: Unconfirmed)
We do not scale it with zoom either (not surprising since we now do device scale factor using zoom). We draw more dots/wiggles/whatever to fill the space under the word, but they appear to always be the same size dots.

Comment 4 by schenney@chromium.org, Jan 31 2017

Components: -UI>HighDPI -Blink>Editing>Spellcheck

Comment 5 by osh...@chromium.org, Jan 31 2017

Owner: malaykeshav@chromium.org
Status: Assigned (was: Available)

Comment 6 by schenney@chromium.org, Jan 31 2017 

I'm already in the process of fixing this because the change is in GraphicsContext, but wanted to verify I could before assigning to myself. Has work started elsewhere?

Comment 7 by bsep@chromium.org, Jan 31 2017

Cc: bsep@chromium.org malaykeshav@chromium.org osh...@chromium.org
 Issue 651529  has been merged into this issue.

Comment 8 by schenney@chromium.org, Feb 1 2017

Cc: -schenney@chromium.org
Owner: schenney@chromium.org
Status: Started (was: Assigned)
I have a patch that fixes this and just need tests.

Comment 9 by schenney@chromium.org, Feb 1 2017 

There's no way to create markers in layout tests, as far as I can tell, and we need to see actual pixels to verify this issue. I think we need test coverage of this code so I am going to spend time writing up the JS test runner bindings to enable marker creation for layout tests.

Speak now if you disagree.

Comment 11 by schenney@chromium.org, Feb 8 2017

Cc: schenney@chromium.org
Owner: fmalita@chromium.org
fmalita@ has a second fix in the commit queue that look better at high zoom.
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b09cbee7a1edeb61ea0a594ac800090f62cb4248

commit b09cbee7a1edeb61ea0a594ac800090f62cb4248
Author: fmalita <fmalita@chromium.org>
Date: Wed Feb 08 17:30:10 2017

Scalable spelling/grammar markers

Replace the inlined bitmap markers with vector drawings, to improve rendering
at arbitrary zoom levels.  Use cached SKP recordings for marker fragments, and
a picture shader for tiling in X.

In order to minimize disruption, this change aims to keep rendering as close
to the original bitmaps as possible.  This can be revisited in the future
(to e.g. improve dot spacing/distribution on Mac).

Performance should be comparable to the current bitmap shader impl: Skia
caches picture shader tiles, so for a given zoom level all markers should be
hitting the same pre-rasterized cache entry (and essentially devolve into
bitmap shaders).

R=schenney@chromium.org
BUG= 686792 

Review-Url: https://codereview.chromium.org/2674003002
Cr-Commit-Position: refs/heads/master@{#449024}

[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/linux/editing/spelling/grammar-markers-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/linux/editing/spelling/grammar-markers-hidpi-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/linux/editing/spelling/inline-spelling-markers-hidpi-composited-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/linux/editing/spelling/inline-spelling-markers-hidpi-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/linux/editing/spelling/inline_spelling_markers-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/document-markers-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/document-markers-zoom-125-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/document-markers-zoom-150-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/document-markers-zoom-175-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/document-markers-zoom-200-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/document-markers-zoom-250-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/mac/editing/spelling/grammar-markers-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/mac/editing/spelling/grammar-markers-hidpi-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/mac/editing/spelling/inline-spelling-markers-hidpi-composited-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/mac/editing/spelling/inline-spelling-markers-hidpi-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/mac/editing/spelling/inline_spelling_markers-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/document-markers-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/document-markers-zoom-125-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/document-markers-zoom-150-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/document-markers-zoom-175-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/document-markers-zoom-200-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/document-markers-zoom-250-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/win/editing/spelling/grammar-markers-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/win/editing/spelling/grammar-markers-hidpi-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/win/editing/spelling/inline-spelling-markers-hidpi-composited-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/win/editing/spelling/inline-spelling-markers-hidpi-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/win/editing/spelling/inline_spelling_markers-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/document-markers-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/document-markers-zoom-125-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/document-markers-zoom-150-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/document-markers-zoom-175-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/document-markers-zoom-200-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/document-markers-zoom-250-expected.png
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp
[modify] https://crrev.com/b09cbee7a1edeb61ea0a594ac800090f62cb4248/third_party/WebKit/Source/platform/graphics/GraphicsContext.h

Comment 13 by fmalita@chromium.org, Feb 8 2017

Status: Fixed (was: Started)

Comment 14 by yoichio@chromium.org, Nov 26

Cc: yoichio@chromium.org groby@chromium.org rouslan@chromium.org le...@chromium.org yosin@chromium.org
 Issue 454943  has been merged into this issue.
►

Sign in to add a comment