New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 686778 link

Starred by 1 user
Status: Fixed
Owner:
jkrcal@chromium.org
Closed: Feb 2017
Cc:
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 645917



Sign in to add a comment

Clean up variation params for NTPArticleSuggestions feature

Project Member Reported by jkrcal@chromium.org, Jan 30 2017 
As per offline discussion with treb@, we should
 - remove the "fetching_personalization" param
 - remove the "fetching_requires_signin" param
 - associate the "content_suggestions_backend" param by the feature
 - associate the request_throttler params by the feature.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f74de5a3c99c463ae51c090d53770fb52f4ebeb4

commit f74de5a3c99c463ae51c090d53770fb52f4ebeb4
Author: jkrcal <jkrcal@chromium.org>
Date: Tue Jan 31 09:23:08 2017

[Remote suggestions] Clean up variation params in the request throttler

This CL associates the variation parameters in the request throttler to
the NTPArticleSuggestions feature. This will streamline the configs.

BUG= 686778 

Review-Url: https://codereview.chromium.org/2660953002
Cr-Commit-Position: refs/heads/master@{#447212}

[modify] https://crrev.com/f74de5a3c99c463ae51c090d53770fb52f4ebeb4/components/ntp_snippets/remote/request_throttler.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f18de6670998bc95c8cfda363cb84291471f2394

commit f18de6670998bc95c8cfda363cb84291471f2394
Author: jkrcal <jkrcal@chromium.org>
Date: Fri Feb 03 14:37:19 2017

[Remote suggestions] Clean up variation params in the fetcher.

This CL removes one obsolete variation param and associate another one by
the feature name.

BUG= 686778 

Review-Url: https://codereview.chromium.org/2665743002
Cr-Commit-Position: refs/heads/master@{#447992}

[modify] https://crrev.com/f18de6670998bc95c8cfda363cb84291471f2394/chrome/browser/about_flags.cc
[modify] https://crrev.com/f18de6670998bc95c8cfda363cb84291471f2394/chrome/browser/ui/webui/snippets_internals_message_handler.cc
[modify] https://crrev.com/f18de6670998bc95c8cfda363cb84291471f2394/components/ntp_snippets/remote/json_request.cc
[modify] https://crrev.com/f18de6670998bc95c8cfda363cb84291471f2394/components/ntp_snippets/remote/json_request.h
[modify] https://crrev.com/f18de6670998bc95c8cfda363cb84291471f2394/components/ntp_snippets/remote/json_request_unittest.cc
[modify] https://crrev.com/f18de6670998bc95c8cfda363cb84291471f2394/components/ntp_snippets/remote/remote_suggestions_fetcher.cc
[modify] https://crrev.com/f18de6670998bc95c8cfda363cb84291471f2394/components/ntp_snippets/remote/remote_suggestions_fetcher.h
[modify] https://crrev.com/f18de6670998bc95c8cfda363cb84291471f2394/components/ntp_snippets/remote/remote_suggestions_fetcher_unittest.cc
[modify] https://crrev.com/f18de6670998bc95c8cfda363cb84291471f2394/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc
[modify] https://crrev.com/f18de6670998bc95c8cfda363cb84291471f2394/components/ntp_snippets/remote/request_params.h

Comment 4 by jkrcal@chromium.org, Feb 8 2017

Status: Fixed (was: Started)
►

Sign in to add a comment