New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 686775 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , iOS
Pri: 2
Type: Bug



Sign in to add a comment

DCHECK Check failed: typed_count > 0.

Project Member Reported by justincohen@chromium.org, Jan 30 2017

Issue description

This is happening on iOS:
[0130/113107.409786:FATAL:typed_url_syncable_service.cc(900)] Check failed: typed_count > 0. 


p url
(const history::URLRow) $1 = {
  id_ = 424
  url_ = {
    spec_ = "http://www.google.com/"
...


#0  0x0000000101100554 in base::debug::BreakDebugger() at base/debug/debugger_posix.cc:251
#1  0x000000010115c1dc in logging::LogMessage::~LogMessage() at base/logging.cc:759
#2  0x0000000101159680 in logging::LogMessage::~LogMessage() at base/logging.cc:533
#3  0x0000000103847c08 in history::TypedUrlSyncableService::WriteToTypedUrlSpecifics(history::URLRow const&, std::__1::vector<history::VisitRow, std::__1::allocator<history::VisitRow> > const&, sync_pb::TypedUrlSpecifics*) at components/history/core/browser/typed_url_syncable_service.cc:900
#4  0x0000000103840b84 in history::TypedUrlSyncableService::AddTypedUrlToChangeList(syncer::SyncChange::SyncChangeType, history::URLRow const&, std::__1::vector<history::VisitRow, std::__1::allocator<history::VisitRow> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::vector<syncer::SyncChange, std::__1::allocator<syncer::SyncChange> >*) at components/history/core/browser/typed_url_syncable_service.cc:853
#5  0x000000010383def0 in history::TypedUrlSyncableService::MergeDataAndStartSyncing(syncer::ModelType, std::__1::vector<syncer::SyncData, std::__1::allocator<syncer::SyncData> > const&, std::__1::unique_ptr<syncer::SyncChangeProcessor, std::__1::default_delete<syncer::SyncChangeProcessor> >, std::__1::unique_ptr<syncer::SyncErrorFactory, std::__1::default_delete<syncer::SyncErrorFactory> >) at components/history/core/browser/typed_url_syncable_service.cc:188
#6  0x0000000102a6fd98 in syncer::SharedChangeProcessor::StartAssociation(base::Callback<void (syncer::DataTypeController::ConfigureResult, syncer::SyncMergeResult const&, syncer::SyncMergeResult const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1>, syncer::SyncClient*, syncer::GenericChangeProcessorFactory*, syncer::UserShare*, std::__1::unique_ptr<syncer::DataTypeErrorHandler, std::__1::default_delete<syncer::DataTypeErrorHandler> >) at components/sync/driver/shared_change_processor.cc:122
#7  0x00000001029f0120 in void base::internal::FunctorTraits<void (syncer::SharedChangeProcessor::*)(base::Callback<void (syncer::DataTypeController::ConfigureResult, syncer::SyncMergeResult const&, syncer::SyncMergeResult const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1>, syncer::SyncClient*, syncer::GenericChangeProcessorFactory*, syncer::UserShare*, std::__1::unique_ptr<syncer::DataTypeErrorHandler, std::__1::default_delete<syncer::DataTypeErrorHandler> >), void>::Invoke<scoped_refptr<syncer::SharedChangeProcessor> const&, base::Callback<void (syncer::DataTypeController::ConfigureResult, syncer::SyncMergeResult const&, syncer::SyncMergeResult const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, syncer::SyncClient* const&, syncer::GenericChangeProcessorFactory* const&, syncer::UserShare* const&, std::__1::unique_ptr<syncer::DataTypeErrorHandler, std::__1::default_delete<syncer::DataTypeErrorHandler> > >(void (syncer::SharedChangeProcessor::*)(base::Callback<void (syncer::DataTypeController::ConfigureResult, syncer::SyncMergeResult const&, syncer::SyncMergeResult const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1>, syncer::SyncClient*, syncer::GenericChangeProcessorFactory*, syncer::UserShare*, std::__1::unique_ptr<syncer::DataTypeErrorHandler, std::__1::default_delete<syncer::DataTypeErrorHandler> >), scoped_refptr<syncer::SharedChangeProcessor> const&&&, base::Callback<void (syncer::DataTypeController::ConfigureResult, syncer::SyncMergeResult const&, syncer::SyncMergeResult const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&&&, syncer::SyncClient* const&&&, syncer::GenericChangeProcessorFactory* const&&&, syncer::UserShare* const&&&, std::__1::unique_ptr<syncer::DataTypeErrorHandler, std::__1::default_delete<syncer::DataTypeErrorHandler> >&&) at base/bind_internal.h:214
#8  0x00000001029efdb4 in void base::internal::InvokeHelper<false, void>::MakeItSo<void (syncer::SharedChangeProcessor::* const&)(base::Callback<void (syncer::DataTypeController::ConfigureResult, syncer::SyncMergeResult const&, syncer::SyncMergeResult const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1>, syncer::SyncClient*, syncer::GenericChangeProcessorFactory*, syncer::UserShare*, std::__1::unique_ptr<syncer::DataTypeErrorHandler, std::__1::default_delete<syncer::DataTypeErrorHandler> >), scoped_refptr<syncer::SharedChangeProcessor> const&, base::Callback<void (syncer::DataTypeController::ConfigureResult, syncer::SyncMergeResult const&, syncer::SyncMergeResult const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, syncer::SyncClient* const&, syncer::GenericChangeProcessorFactory* const&, syncer::UserShare* const&, std::__1::unique_ptr<syncer::DataTypeErrorHandler, std::__1::default_delete<syncer::DataTypeErrorHandler> > >(void (syncer::SharedChangeProcessor::* const&&&)(base::Callback<void (syncer::DataTypeController::ConfigureResult, syncer::SyncMergeResult const&, syncer::SyncMergeResult const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1>, syncer::SyncClient*, syncer::GenericChangeProcessorFactory*, syncer::UserShare*, std::__1::unique_ptr<syncer::DataTypeErrorHandler, std::__1::default_delete<syncer::DataTypeErrorHandler> >), scoped_refptr<syncer::SharedChangeProcessor> const&&&, base::Callback<void (syncer::DataTypeController::ConfigureResult, syncer::SyncMergeResult const&, syncer::SyncMergeResult const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&&&, syncer::SyncClient* const&&&, syncer::GenericChangeProcessorFactory* const&&&, syncer::UserShare* const&&&, std::__1::unique_ptr<syncer::DataTypeErrorHandler, std::__1::default_delete<syncer::DataTypeErrorHandler> >&&) at base/bind_internal.h:285
#9  0x00000001029efc58 in void base::internal::Invoker<base::internal::BindState<void (syncer::SharedChangeProcessor::*)(base::Callback<void (syncer::DataTypeController::ConfigureResult, syncer::SyncMergeResult const&, syncer::SyncMergeResult const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1>, syncer::SyncClient*, syncer::GenericChangeProcessorFactory*, syncer::UserShare*, std::__1::unique_ptr<syncer::DataTypeErrorHandler, std::__1::default_delete<syncer::DataTypeErrorHandler> >), scoped_refptr<syncer::SharedChangeProcessor>, base::Callback<void (syncer::DataTypeController::ConfigureResult, syncer::SyncMergeResult const&, syncer::SyncMergeResult const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1>, syncer::SyncClient*, syncer::GenericChangeProcessorFactory*, syncer::UserShare*, base::internal::PassedWrapper<std::__1::unique_ptr<syncer::DataTypeErrorHandler, std::__1::default_delete<syncer::DataTypeErrorHandler> > > >, void ()>::RunImpl<void (syncer::SharedChangeProcessor::* const&)(base::Callback<void (syncer::DataTypeController::ConfigureResult, syncer::SyncMergeResult const&, syncer::SyncMergeResult const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1>, syncer::SyncClient*, syncer::GenericChangeProcessorFactory*, syncer::UserShare*, std::__1::unique_ptr<syncer::DataTypeErrorHandler, std::__1::default_delete<syncer::DataTypeErrorHandler> >), std::__1::tuple<scoped_refptr<syncer::SharedChangeProcessor>, base::Callback<void (syncer::DataTypeController::ConfigureResult, syncer::SyncMergeResult const&, syncer::SyncMergeResult const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1>, syncer::SyncClient*, syncer::GenericChangeProcessorFactory*, syncer::UserShare*, base::internal::PassedWrapper<std::__1::unique_ptr<syncer::DataTypeErrorHandler, std::__1::default_delete<syncer::DataTypeErrorHandler> > > > const&, 0ul, 1ul, 2ul, 3ul, 4ul, 5ul>(void (syncer::SharedChangeProcessor::* const&&&)(base::Callback<void (syncer::DataTypeController::ConfigureResult, syncer::SyncMergeResult const&, syncer::SyncMergeResult const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1>, syncer::SyncClient*, syncer::GenericChangeProcessorFactory*, syncer::UserShare*, std::__1::unique_ptr<syncer::DataTypeErrorHandler, std::__1::default_delete<syncer::DataTypeErrorHandler> >), std::__1::tuple<scoped_refptr<syncer::SharedChangeProcessor>, base::Callback<void (syncer::DataTypeController::ConfigureResult, syncer::SyncMergeResult const&, syncer::SyncMergeResult const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1>, syncer::SyncClient*, syncer::GenericChangeProcessorFactory*, syncer::UserShare*, base::internal::PassedWrapper<std::__1::unique_ptr<syncer::DataTypeErrorHandler, std::__1::default_delete<syncer::DataTypeErrorHandler> > > > const&&&, base::IndexSequence<0ul, 1ul, 2ul, 3ul, 4ul, 5ul>) at base/bind_internal.h:361
#10 0x00000001029efa9c in base::internal::Invoker<base::internal::BindState<void (syncer::SharedChangeProcessor::*)(base::Callback<void (syncer::DataTypeController::ConfigureResult, syncer::SyncMergeResult const&, syncer::SyncMergeResult const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1>, syncer::SyncClient*, syncer::GenericChangeProcessorFactory*, syncer::UserShare*, std::__1::unique_ptr<syncer::DataTypeErrorHandler, std::__1::default_delete<syncer::DataTypeErrorHandler> >), scoped_refptr<syncer::SharedChangeProcessor>, base::Callback<void (syncer::DataTypeController::ConfigureResult, syncer::SyncMergeResult const&, syncer::SyncMergeResult const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1>, syncer::SyncClient*, syncer::GenericChangeProcessorFactory*, syncer::UserShare*, base::internal::PassedWrapper<std::__1::unique_ptr<syncer::DataTypeErrorHandler, std::__1::default_delete<syncer::DataTypeErrorHandler> > > >, void ()>::Run(base::internal::BindStateBase*) at base/bind_internal.h:339
#11 0x00000001001c58b8 in base::internal::RunMixin<base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> >::Run() const at base/callback.h:85
#12 0x0000000103839f34 in browser_sync::(anonymous namespace)::RunTaskOnHistoryThread::RunOnDBThread(history::HistoryBackend*, history::HistoryDatabase*) at components/history/core/browser/typed_url_data_type_controller.cc:35
#13 0x000000010377de44 in history::QueuedHistoryDBTask::Run(history::HistoryBackend*, history::HistoryDatabase*) at components/history/core/browser/history_backend.cc:179
#14 0x00000001037946f8 in history::HistoryBackend::ProcessDBTaskImpl() at components/history/core/browser/history_backend.cc:2283
#15 0x000000010379741c in history::HistoryBackend::ProcessDBTask(std::__1::unique_ptr<history::HistoryDBTask, std::__1::default_delete<history::HistoryDBTask> >, scoped_refptr<base::SingleThreadTaskRunner>, base::Callback<bool (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) at components/history/core/browser/history_backend.cc:2487
#16 0x00000001037d436c in void base::internal::FunctorTraits<void (history::HistoryBackend::*)(std::__1::unique_ptr<history::HistoryDBTask, std::__1::default_delete<history::HistoryDBTask> >, scoped_refptr<base::SingleThreadTaskRunner>, base::Callback<bool (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&), void>::Invoke<scoped_refptr<history::HistoryBackend> const&, std::__1::unique_ptr<history::HistoryDBTask, std::__1::default_delete<history::HistoryDBTask> >, scoped_refptr<base::SingleThreadTaskRunner> const&, base::Callback<bool (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&>(void (history::HistoryBackend::*)(std::__1::unique_ptr<history::HistoryDBTask, std::__1::default_delete<history::HistoryDBTask> >, scoped_refptr<base::SingleThreadTaskRunner>, base::Callback<bool (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&), scoped_refptr<history::HistoryBackend> const&&&, std::__1::unique_ptr<history::HistoryDBTask, std::__1::default_delete<history::HistoryDBTask> >&&, scoped_refptr<base::SingleThreadTaskRunner> const&&&, base::Callback<bool (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&&&) at base/bind_internal.h:214
#17 0x00000001037d40d4 in void base::internal::InvokeHelper<false, void>::MakeItSo<void (history::HistoryBackend::* const&)(std::__1::unique_ptr<history::HistoryDBTask, std::__1::default_delete<history::HistoryDBTask> >, scoped_refptr<base::SingleThreadTaskRunner>, base::Callback<bool (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&), scoped_refptr<history::HistoryBackend> const&, std::__1::unique_ptr<history::HistoryDBTask, std::__1::default_delete<history::HistoryDBTask> >, scoped_refptr<base::SingleThreadTaskRunner> const&, base::Callback<bool (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&>(void (history::HistoryBackend::* const&&&)(std::__1::unique_ptr<history::HistoryDBTask, std::__1::default_delete<history::HistoryDBTask> >, scoped_refptr<base::SingleThreadTaskRunner>, base::Callback<bool (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&), scoped_refptr<history::HistoryBackend> const&&&, std::__1::unique_ptr<history::HistoryDBTask, std::__1::default_delete<history::HistoryDBTask> >&&, scoped_refptr<base::SingleThreadTaskRunner> const&&&, base::Callback<bool (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&&&) at base/bind_internal.h:285
#18 0x00000001037d3f9c in void base::internal::Invoker<base::internal::BindState<void (history::HistoryBackend::*)(std::__1::unique_ptr<history::HistoryDBTask, std::__1::default_delete<history::HistoryDBTask> >, scoped_refptr<base::SingleThreadTaskRunner>, base::Callback<bool (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&), scoped_refptr<history::HistoryBackend>, base::internal::PassedWrapper<std::__1::unique_ptr<history::HistoryDBTask, std::__1::default_delete<history::HistoryDBTask> > >, scoped_refptr<base::SingleThreadTaskRunner>, base::Callback<bool (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> >, void ()>::RunImpl<void (history::HistoryBackend::* const&)(std::__1::unique_ptr<history::HistoryDBTask, std::__1::default_delete<history::HistoryDBTask> >, scoped_refptr<base::SingleThreadTaskRunner>, base::Callback<bool (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&), std::__1::tuple<scoped_refptr<history::HistoryBackend>, base::internal::PassedWrapper<std::__1::unique_ptr<history::HistoryDBTask, std::__1::default_delete<history::HistoryDBTask> > >, scoped_refptr<base::SingleThreadTaskRunner>, base::Callback<bool (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> > const&, 0ul, 1ul, 2ul, 3ul>(void (history::HistoryBackend::* const&&&)(std::__1::unique_ptr<history::HistoryDBTask, std::__1::default_delete<history::HistoryDBTask> >, scoped_refptr<base::SingleThreadTaskRunner>, base::Callback<bool (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&), std::__1::tuple<scoped_refptr<history::HistoryBackend>, base::internal::PassedWrapper<std::__1::unique_ptr<history::HistoryDBTask, std::__1::default_delete<history::HistoryDBTask> > >, scoped_refptr<base::SingleThreadTaskRunner>, base::Callback<bool (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> > const&&&, base::IndexSequence<0ul, 1ul, 2ul, 3ul>) at base/bind_internal.h:361
#19 0x00000001037d3e58 in base::internal::Invoker<base::internal::BindState<void (history::HistoryBackend::*)(std::__1::unique_ptr<history::HistoryDBTask, std::__1::default_delete<history::HistoryDBTask> >, scoped_refptr<base::SingleThreadTaskRunner>, base::Callback<bool (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&), scoped_refptr<history::HistoryBackend>, base::internal::PassedWrapper<std::__1::unique_ptr<history::HistoryDBTask, std::__1::default_delete<history::HistoryDBTask> > >, scoped_refptr<base::SingleThreadTaskRunner>, base::Callback<bool (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> >, void ()>::Run(base::internal::BindStateBase*) at base/bind_internal.h:339
#20 0x00000001012cafdc in base::internal::RunMixin<base::Callback<void (), (base::internal::CopyMode)0, (base::internal::RepeatMode)0> >::Run() at base/callback.h:68
#21 0x00000001011031a0 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) at base/debug/task_annotator.cc:52
#22 0x000000010117b10c in base::MessageLoop::RunTask(base::PendingTask*) at base/message_loop/message_loop.cc:421
#23 0x000000010117b548 in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) at base/message_loop/message_loop.cc:430
#24 0x000000010117bd8c in base::MessageLoop::DoWork() at base/message_loop/message_loop.cc:523
#25 0x00000001013a6d94 in base::MessagePumpCFRunLoopBase::RunWork() at base/message_loop/message_pump_mac.mm:302
#26 0x00000001013a6d2c in ::___ZN4base24MessagePumpCFRunLoopBase13RunWorkSourceEPv_block_invoke() at base/message_loop/message_pump_mac.mm:279
#27 0x0000000101396580 in base::mac::CallWithEHFrame(void () block_pointer) at base/mac/call_with_eh_frame.cc:18
#28 0x00000001013a647c in base::MessagePumpCFRunLoopBase::RunWorkSource(void*) at base/message_loop/message_pump_mac.mm:278
#29 0x0000000188276b5c in __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ ()
#30 0x00000001882764a4 in __CFRunLoopDoSources0 ()
#31 0x00000001882740a4 in __CFRunLoopRun ()
#32 0x00000001881a22b8 in CFRunLoopRunSpecific ()
#33 0x00000001013a7444 in base::MessagePumpCFRunLoop::DoRun(base::MessagePump::Delegate*) at base/message_loop/message_pump_mac.mm:526
#34 0x00000001013a6b50 in base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) at base/message_loop/message_pump_mac.mm:210
#35 0x000000010117acbc in base::MessageLoop::RunHandler() at base/message_loop/message_loop.cc:386
#36 0x000000010120a054 in base::RunLoop::Run() at base/run_loop.cc:37
#37 0x00000001012bbef8 in base::Thread::Run(base::RunLoop*) at base/threading/thread.cc:250
#38 0x00000001012bcc48 in base::Thread::ThreadMain() at base/threading/thread.cc:333
#39 0x00000001012a1248 in base::(anonymous namespace)::ThreadFunc(void*) at base/threading/platform_thread_posix.cc:71
#40 0x000000018735d850 in _pthread_body ()
#41 0x000000018735d760 in _pthread_start ()
#42 0x000000018735ad94 in thread_start ()


about:omnibox output as an image, since it doesn't cut and paste well:
  https://screenshot.googleplex.com/HmJYk7q010T

And the useless paste:
Provider	Type	Relevance	Contents	Can Be Default	Starred	Description	URL	Fill Into Edit	Inline Autocompletion	Del	Prev	Tran	Done	Associated Keyword	Keyword	Duplicates	Additional Info
HistoryURL	url-what-you-typed	1203	http://www.google.com	✔	✔	Google	http://www.google.com/	http://www.google.com		✔	✗	1	✔			1	
last visit:	1/30/17, 10:07:14 AM
typed count:	0
visit count:	223
Search	navsuggest	1350	https://www.google.com	✗	✔	Google	https://www.google.com/	https://www.google.com		✗	✗	1	✔			1	
relevance_from_server:	true
should_prefetch:	false
Bookmark	bookmark-title	1181	https://www.google.com/analytics/home/	✗	✔	Google Analytics	https://www.google.com/analytics/home/	https://www.google.com/analytics/home/		✗	✗	1	✔			0	
Search	search-what-you-typed	850	http://www.google.com	✔	✗	Google Search	https://www.google.com/search?q=http%3A%2F%2Fwww.google.com&oq=http%3A%2F%2Fwww.google.com&aqs=chrome..69i58j5j69i65j69i57j5l2&sourceid=chrome&ie=UTF-8	http://www.google.com		✗	✗	5	✔		google.com__	0	
relevance_from_server:	false
should_prefetch:	false
Search	navsuggest	818	http://www.google.com/device	✗	✗		http://www.google.com/device	http://www.google.com/device	/device	✗	✗	1	✔			0	
relevance_from_server:	true
should_prefetch:	false
Search	navsuggest	817	https://www.google.com/?client=ms-android-att-us	✗	✗		https://www.google.com/?client=ms-android-att-us

 

Comment 1 by pkl@chromium.org, Jan 30 2017

Components: Services>Sync
Labels: M-58
Owner: zea@chromium.org
Status: Assigned (was: Untriaged)
Are you aware of any recent changes in sync that might have caused this?

Comment 2 by zea@chromium.org, Jan 31 2017

Owner: gangwu@chromium.org
Not as far as I'm aware. Gang, any idea what's going on?

Comment 3 by s...@chromium.org, Feb 15 2017

Cc: s...@chromium.org
 Issue 692493  has been merged into this issue.

Comment 4 by s...@chromium.org, Feb 15 2017

Cc: grt@chromium.org sky@chromium.org
Labels: OS-Windows

Comment 5 by gangwu@chromium.org, Feb 17 2017

the problem might because of https://cs.chromium.org/chromium/src/components/history/core/browser/typed_url_syncable_service.cc?l=938, searched history, it seems before syncable service, sync ignore URLs with no visits, so we might need to use previous way to handle URLs with no visits, rather than create a fake one.

Comment 6 by grt@chromium.org, Mar 3 2017

skym: for me, the crash happens at startup during session restore -- far earlier than ~9 seconds after startup. The crash is within HistoryBackend::ProcessDBTask, as posted from HistoryService::ScheduleDBTask during syncer::AsyncDirectoryTypeController::StartDone. You have my permission to look at the sync data for my chromium.org account if that'll help. Is there anything in my local history that I could dig up to help diagnose?
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d4ced0b8d7081318da910aff495ed4f5f38f63e

commit 3d4ced0b8d7081318da910aff495ed4f5f38f63e
Author: gangwu <gangwu@chromium.org>
Date: Thu Mar 09 00:13:43 2017

[Sync] Sync do not sync Typed URL when updating an URL that wasn't typed

Ignore an URL when the URL does not have typed visit

BUG= 686775 

previously, synced_typed_urls_.insert new url before or after
AddTypedUrlToChangeList, now I move this into AddTypedUrlToChangeList.

Review-Url: https://codereview.chromium.org/2738843002
Cr-Commit-Position: refs/heads/master@{#455604}

[modify] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/components/browser_sync/profile_sync_service_typed_url_unittest.cc
[modify] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/components/history/core/browser/typed_url_syncable_service.cc
[modify] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/components/history/core/browser/typed_url_syncable_service.h
[modify] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/components/history/core/browser/typed_url_syncable_service_unittest.cc

Comment 8 by gangwu@chromium.org, Mar 22 2017

Status: Fixed (was: Assigned)

Sign in to add a comment