Fullscreen API no longer works on touchstart |
||||
Issue descriptionSteps to reproduce the problem: 1. Visit https://www.google.com/logos/2015/beethoven15/beethoven15.html?hl=en 2. Interact with the doodle What is the expected behavior? The page goes fullscreen; up until Chrome 56 this worked. What went wrong? The page does not go fullscreen. Changing to use touchend instead of touchstart works, but I am 100% certain touchstart worked before Chrome 56. Did this work before? N/A Does this work in other browsers? Yes Chrome version: 56.0.2924.76 Channel: stable OS Version: Flash Version: Saw crbug/671554, but that seems different because it implies that touchstart never worked.
,
Jan 30 2017
tdresser@ says touchstart isn't considered a user gesture, because we don't want scrolls count as user gestures.
,
Jan 30 2017
Ok makes sense. It's a bummer that this changed without any notification though. How do you normally handle bugfixes like this? I feel like in the past I've seen console warnings about looming changes in functionality a couple releases in advance. (Something like "Warning: Touchstart events will no longer qualify as user gestures starting in Chrome 56)
,
Jan 30 2017
,
Jan 30 2017
See issue 611981 for more context.
,
Jan 30 2017
There was a warning I guess you didn't see it. Here is the text of the warning.. https://codereview.chromium.org/2027473002/patch/1/10005
,
Jan 30 2017
Oh wow I did see that warning but thought it meant pretty much the exact opposite. "Performing operations that require explicit user interaction on touchstart events will be removed." reads to me as, "this action that you just requested will no longer be required to be a direct result of a touchstart event". Like it would no longer require a user gesture. In fact, I've seen this warning for months and never read it any differently. Very confusing wording IMO.
,
Jan 30 2017
Good to know it was mis-understood by you. Did you not click the associated link to read more? I presume this cases isn't cross-origin at all so this also kind of mislead you? I'm just trying to understand what we could have done better.
,
Jan 30 2017
No I didn't click the read more link because the wording didn't seem confusing - it seemed to be very straightforwardly saying what I interpreted it as. Good to know I should just always click the link in the future. In terms of better wording, I think "Warning: Touchstart events will no longer qualify as user gestures starting in Chrome 56" would have been much clearer. Also, sorry, but how does cross-origin relate to this?
,
Jan 30 2017
In order to fix the cross-origin problem we needed to stop making touch-start being a user-gesture; so it definitely got confusing on that front. We appreciate your feedback. |
||||
►
Sign in to add a comment |
||||
Comment 1 by jordanthompson@google.com
, Jan 30 2017