New issue
Advanced search Search tips

Issue 686743 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Missing Tests]: UnlockProfileAndHideLoginUI() will be called once the sign in is almost finished

Project Member Reported by durga.behera@chromium.org, Jan 30 2017

Issue description

pmonette@, Automated tests for the below commit have been missing and would be really great to add them ASAP since these issues are high priority regressions.

Commit: https://codereview.chromium.org/2519123003

Ref. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=667227

Thank you!
 
Owner: zmin@chromium.org
Reassigning to Owen. 
Project Member

Comment 2 by sheriffbot@chromium.org, Mar 1 2017

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49f6220a80ff68d06c6c1c5179d0e494e0b8ad00

commit 49f6220a80ff68d06c6c1c5179d0e494e0b8ad00
Author: zmin <zmin@chromium.org>
Date: Fri Mar 24 18:58:58 2017

Allow sign in while browser is opened when force-sign-in policy is enabled.

Because force-sign-in policy won't force browser window closing before sign out when user is using Chrome,
force-sign-in policy will support sign in with browser opened.
Also add some browser test.

BUG= 642059 
BUG= 681230 
BUG= 682661 
BUG= 686743 

Review-Url: https://codereview.chromium.org/2760423002
Cr-Commit-Position: refs/heads/master@{#459501}

[modify] https://crrev.com/49f6220a80ff68d06c6c1c5179d0e494e0b8ad00/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
[modify] https://crrev.com/49f6220a80ff68d06c6c1c5179d0e494e0b8ad00/chrome/browser/ui/webui/signin/inline_login_handler_impl.h
[modify] https://crrev.com/49f6220a80ff68d06c6c1c5179d0e494e0b8ad00/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

Comment 4 by zmin@chromium.org, Apr 20 2017

Status: Fixed (was: Available)

Sign in to add a comment