New issue
Advanced search Search tips

Issue 686735 link

Starred by 1 user
Status: Fixed
Owner:
mea...@chromium.org
Closed: Feb 2017
Cc:
ligim...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Missing Tests]: Re-enable HttpsEngagementMetricsProvider

Project Member Reported by durga.behera@chromium.org, Jan 30 2017 
meacer@, Automated tests for the below commit have been missing and would be really great to add them ASAP since these issues are high priority regressions.

Commit: 

Ref. Bug: 

Thank you!

Comment 2 by mea...@chromium.org, Jan 30 2017 

HttpsEngagementMetricsProvider is already being tested by HttpsEngagementPageLoadMetricsBrowserTest.* tests. The code in the fixed bug wasn't handling profile initializations and shutdowns properly, and I'm not sure what additional we can add for that.

Comment 3 by mea...@chromium.org, Feb 9 2017 

Ping. I believe this code is fairly well tested already. Can this bug be closed?

Comment 4 by ligim...@chromium.org, Feb 9 2017 

Yes sure, please feel free to close the bug.

Comment 5 by mea...@chromium.org, Feb 9 2017

Status: Fixed (was: Assigned)
Thanks!
►

Sign in to add a comment