New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 686734 link

Starred by 1 user
Status: Archived
Owner:
tedc...@chromium.org
Closed: Nov 21
Cc:
█ dfalcant...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: ----

Blocking:
issue 661560



Sign in to add a comment

InfoBarContainerTests failing on chromium.android/KitKat Tablet Tester

Project Member Reported by dgn@chromium.org, Jan 30 2017 
chrome_public_test_apk failing on chromium.android/KitKat Tablet Tester

Type: build-failure

Builders failed on: 
- KitKat Tablet Tester
- Android Tests (dbg): https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20(dbg)/builds/39458
  

Flakiness dashboard link:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=InfoBarContainerTest

Sample failure:

org.chromium.chrome.browser.infobar.InfoBarContainerTest#testAddAndDismissSurfaceFlingerOverlays (run #2):
java.util.concurrent.TimeoutException: InfoBar not added.
	at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:183)
	at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:211)
	at org.chromium.chrome.test.util.InfoBarTestAnimationListener.addInfoBarAnimationFinished(InfoBarTestAnimationListener.java:50)
	at org.chromium.chrome.browser.infobar.InfoBarContainerTest.addInfoBarToCurrentTab(InfoBarContainerTest.java:102)
	at org.chromium.chrome.browser.infobar.InfoBarContainerTest.testAddAndDismissSurfaceFlingerOverlays(InfoBarContainerTest.java:293)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:752)
	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)


Suspected CL: https://codereview.chromium.org/2662613003
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da00ce3b58c2116e88defdf99339ac9b503ceecc

commit da00ce3b58c2116e88defdf99339ac9b503ceecc
Author: dgn <dgn@chromium.org>
Date: Mon Jan 30 15:21:37 2017

Revert of [Android] Mark infobars as gone when they are off the screen (patchset #3 id:40001 of https://codereview.chromium.org/2662613003/ )

Reason for revert:
Suspected for causing failures on testers:

org.chromium.chrome.browser.infobar.InfoBarContainerTest#testAddAndDismissSurfaceFlingerOverlays (run #2):
java.util.concurrent.TimeoutException: InfoBar not added.
	at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:183)
	at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:211)
	at org.chromium.chrome.test.util.InfoBarTestAnimationListener.addInfoBarAnimationFinished(InfoBarTestAnimationListener.java:50)

BUG= 686734 

Original issue's description:
> [Android] Mark infobars as gone when they are off the screen
>
> Infobars are translated off the screen when users scroll up. Yet they
> still are thought as non-transparent regions on top of surface view.
> This CL optimizes this case by setting the visibility to gone when
> infobars are not visible.
>
> BUG=661560
>
> Review-Url: https://codereview.chromium.org/2662613003
> Cr-Commit-Position: refs/heads/master@{#446869}
> Committed: https://chromium.googlesource.com/chromium/src/+/45d5cd05e3c01ddbaef79b0d469f34d1c50215f9

TBR=tedchoc@chromium.org,ianwen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=661560

Review-Url: https://codereview.chromium.org/2665663003
Cr-Commit-Position: refs/heads/master@{#446984}

[modify] https://crrev.com/da00ce3b58c2116e88defdf99339ac9b503ceecc/chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java

Comment 2 by dominickn@chromium.org, Jan 31 2017

Cc: dfalcant...@chromium.org
Owner: ----
ianwen@ has left the team. +cc dfalcantara for further triage

Comment 3 by dfalcant...@chromium.org, Jan 31 2017

Owner: tedc...@chromium.org
Ted: you reviewed the patch that got reverted.  Do you know what that was supposed to address?
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 12 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by benhenry@chromium.org, Aug 3

Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".

Comment 6 by agrieve@google.com, Nov 21

Status: Archived (was: Assigned)
►

Sign in to add a comment