Creates some glue between the UI and the data provided by ntp_snippets::ContentSuggestions
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/510beda2fad1d10533f1ca49a82bf0860264ccf0 commit 510beda2fad1d10533f1ca49a82bf0860264ccf0 Author: gambard <gambard@chromium.org> Date: Mon Feb 13 15:51:39 2017 Modify article item in ContentSuggestions This CL modifies the Article item of ContentSuggestions to allow it to point to an article URL. BUG= 686728 Review-Url: https://codereview.chromium.org/2697573002 Cr-Commit-Position: refs/heads/master@{#449966} [modify] https://crrev.com/510beda2fad1d10533f1ca49a82bf0860264ccf0/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/510beda2fad1d10533f1ca49a82bf0860264ccf0/ios/chrome/browser/ui/content_suggestions/BUILD.gn [modify] https://crrev.com/510beda2fad1d10533f1ca49a82bf0860264ccf0/ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.h [modify] https://crrev.com/510beda2fad1d10533f1ca49a82bf0860264ccf0/ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.mm [modify] https://crrev.com/510beda2fad1d10533f1ca49a82bf0860264ccf0/ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item_unittest.mm [modify] https://crrev.com/510beda2fad1d10533f1ca49a82bf0860264ccf0/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [modify] https://crrev.com/510beda2fad1d10533f1ca49a82bf0860264ccf0/ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h [modify] https://crrev.com/510beda2fad1d10533f1ca49a82bf0860264ccf0/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [modify] https://crrev.com/510beda2fad1d10533f1ca49a82bf0860264ccf0/ios/showcase/common/protocol_alerter.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79a649cdaa78cd9f9b6c040b1bccc89c7efcb7e5 commit 79a649cdaa78cd9f9b6c040b1bccc89c7efcb7e5 Author: gambard <gambard@chromium.org> Date: Mon Feb 13 18:15:28 2017 Add Category wrapper for ContentSuggestions on iOS This CL adds an Objective-C wrapper for the ntp_snippets::Category. It also adds a SectionInformation containing the informations relative to a section, like the title, layout, ordering and cell to display when the section is empty. BUG= 686728 Review-Url: https://codereview.chromium.org/2689953003 Cr-Commit-Position: refs/heads/master@{#450012} [modify] https://crrev.com/79a649cdaa78cd9f9b6c040b1bccc89c7efcb7e5/ios/chrome/browser/content_suggestions/BUILD.gn [add] https://crrev.com/79a649cdaa78cd9f9b6c040b1bccc89c7efcb7e5/ios/chrome/browser/content_suggestions/content_suggestions_category_wrapper.h [add] https://crrev.com/79a649cdaa78cd9f9b6c040b1bccc89c7efcb7e5/ios/chrome/browser/content_suggestions/content_suggestions_category_wrapper.mm [add] https://crrev.com/79a649cdaa78cd9f9b6c040b1bccc89c7efcb7e5/ios/chrome/browser/content_suggestions/content_suggestions_category_wrapper_unittest.mm [modify] https://crrev.com/79a649cdaa78cd9f9b6c040b1bccc89c7efcb7e5/ios/chrome/browser/ui/content_suggestions/BUILD.gn [add] https://crrev.com/79a649cdaa78cd9f9b6c040b1bccc89c7efcb7e5/ios/chrome/browser/ui/content_suggestions/content_suggestions_section_information.h [add] https://crrev.com/79a649cdaa78cd9f9b6c040b1bccc89c7efcb7e5/ios/chrome/browser/ui/content_suggestions/content_suggestions_section_information.mm [modify] https://crrev.com/79a649cdaa78cd9f9b6c040b1bccc89c7efcb7e5/ios/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/907dd7c27ec76ec75fad3c9659ba323e83376fd7 commit 907dd7c27ec76ec75fad3c9659ba323e83376fd7 Author: gambard <gambard@chromium.org> Date: Mon Feb 20 09:59:52 2017 Connect ContentSuggestionsMediator to the ContentService ContentSuggestionsMediator expose the suggestions from the ContentService instead of empty ones. BUG= 686728 Review-Url: https://codereview.chromium.org/2691593002 Cr-Commit-Position: refs/heads/master@{#451586} [modify] https://crrev.com/907dd7c27ec76ec75fad3c9659ba323e83376fd7/ios/chrome/browser/content_suggestions/content_suggestions_category_wrapper.h [modify] https://crrev.com/907dd7c27ec76ec75fad3c9659ba323e83376fd7/ios/chrome/browser/content_suggestions/content_suggestions_category_wrapper.mm [modify] https://crrev.com/907dd7c27ec76ec75fad3c9659ba323e83376fd7/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/907dd7c27ec76ec75fad3c9659ba323e83376fd7/ios/chrome/browser/ui/content_suggestions/content_suggestion.h [modify] https://crrev.com/907dd7c27ec76ec75fad3c9659ba323e83376fd7/ios/chrome/browser/ui/content_suggestions/content_suggestion.mm [modify] https://crrev.com/907dd7c27ec76ec75fad3c9659ba323e83376fd7/ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.mm [modify] https://crrev.com/907dd7c27ec76ec75fad3c9659ba323e83376fd7/ios/chrome/browser/ui/content_suggestions/content_suggestions_section_information.h [modify] https://crrev.com/907dd7c27ec76ec75fad3c9659ba323e83376fd7/ios/chrome/browser/ui/content_suggestions/content_suggestions_section_information.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb0cb90ee32bf35e4559cdb1bc3dc12b5ddc17a2 commit fb0cb90ee32bf35e4559cdb1bc3dc12b5ddc17a2 Author: gambard <gambard@chromium.org> Date: Mon Feb 20 10:20:02 2017 Display articles in Content Suggestions Connect the article suggestions from the ContentSuggestionsMediator with the suggestions UI. BUG= 686728 Review-Url: https://codereview.chromium.org/2697843003 Cr-Commit-Position: refs/heads/master@{#451589} [modify] https://crrev.com/fb0cb90ee32bf35e4559cdb1bc3dc12b5ddc17a2/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.h [modify] https://crrev.com/fb0cb90ee32bf35e4559cdb1bc3dc12b5ddc17a2/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [modify] https://crrev.com/fb0cb90ee32bf35e4559cdb1bc3dc12b5ddc17a2/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08dded86021b3231e8db6ea77163b88c036bba76 commit 08dded86021b3231e8db6ea77163b88c036bba76 Author: gambard <gambard@chromium.org> Date: Tue Mar 28 09:32:53 2017 Add a message to empty ContentSuggestions sections This CL adds a message to be displayed in the empty ContentSuggestions sections. BUG= 686728 Review-Url: https://codereview.chromium.org/2775593002 Cr-Commit-Position: refs/heads/master@{#460052} [modify] https://crrev.com/08dded86021b3231e8db6ea77163b88c036bba76/components/ntp_snippets_strings.grdp [modify] https://crrev.com/08dded86021b3231e8db6ea77163b88c036bba76/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/08dded86021b3231e8db6ea77163b88c036bba76/ios/chrome/browser/ui/content_suggestions/BUILD.gn [modify] https://crrev.com/08dded86021b3231e8db6ea77163b88c036bba76/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn [add] https://crrev.com/08dded86021b3231e8db6ea77163b88c036bba76/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_text_item.h [add] https://crrev.com/08dded86021b3231e8db6ea77163b88c036bba76/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_text_item.mm [modify] https://crrev.com/08dded86021b3231e8db6ea77163b88c036bba76/ios/chrome/browser/ui/content_suggestions/content_suggestion.h [modify] https://crrev.com/08dded86021b3231e8db6ea77163b88c036bba76/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.h [modify] https://crrev.com/08dded86021b3231e8db6ea77163b88c036bba76/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [add] https://crrev.com/08dded86021b3231e8db6ea77163b88c036bba76/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater_unittest.mm [modify] https://crrev.com/08dded86021b3231e8db6ea77163b88c036bba76/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [modify] https://crrev.com/08dded86021b3231e8db6ea77163b88c036bba76/ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.h [modify] https://crrev.com/08dded86021b3231e8db6ea77163b88c036bba76/ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.mm [modify] https://crrev.com/08dded86021b3231e8db6ea77163b88c036bba76/ios/chrome/test/BUILD.gn
Comment 1 by bugdroid1@chromium.org
, Feb 13 2017