Move parts of Blink public API that Device Sensors impl uses to be Device Sensors client library |
|||
Issue descriptionCurrently, several Device Sensors client files are part of the WebKit public API (as they are also used by the Blink device sensors client-side code). As part of servicificying Device Sensors and enabling it to be used by clients other than Blink, this dependency from the Device Sensors impl to the WebKit public API should be removed. As illustrated in https://codereview.chromium.org/2415083002/, porting these files to live in a Device Service client library is not possible because WebKit's modules/ dir can't depend on such a client library. Thus, they should instead be ported to Mojom (they are defining data structures shared between the impl and the client).
,
Mar 16 2017
As discussed in https://groups.google.com/a/chromium.org/forum/#!topic/platform-architecture-dev/w3Led4Govow, we actually are going to take the approach of allowing Blink to use these client files from the Device Service. That email thread explains the reasoning.
,
Mar 23 2017
,
Apr 21 2017
http://crrev.com/2646093002 introduced a dependency from device_unittest to blink. blundell mentioned that we should add a TODO to remove the dependency once this issue is fixed. Now that this is fixed can we remove the dependency?
,
Apr 21 2017
Yes, I'll send a CL to remove that dependency. Thanks.
,
Nov 7 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by blundell@chromium.org
, Jan 31 2017