New issue
Advanced search Search tips

Issue 686693 link

Starred by 1 user
Status: Fixed
Owner:
leon....@intel.com
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 686687
issue 689379
Blocking:
issue 612328



Sign in to add a comment

Move //device/vibration impl to be hidden inside the Device Service

Project Member Reported by blundell@chromium.org, Jan 30 2017 
Once the //device/vibration Mojo interface is being exposed to Chromium solely via the Device Service, the //device/vibration impl should be moved to become part of the internal implementation of the Device Service. This means:

- Move //device/vibration to //services/device/vibration
- Make //services/device/vibration visible in GN only to //services/device

Comment 1 by ke...@intel.com, Feb 7 2017

Blockedon: 689379

Comment 2 by leon....@intel.com, Feb 15 2017

Owner: leon....@intel.com
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/619fa1b9313edde43a21f0506e6c16f3ba7ee04f

commit 619fa1b9313edde43a21f0506e6c16f3ba7ee04f
Author: leon.han <leon.han@intel.com>
Date: Wed Apr 19 01:14:29 2017

[DeviceService] Move all vibration codes into //services/device

We have already eliminated all deps on //device/vibration from //content,
so now this CL
- Moves //device/vibration to //services/device/vibration
- Makes //services/device/vibration visible in GN only to
  //services/device

BUG= 686693 

Review-Url: https://codereview.chromium.org/2776983002
Cr-Commit-Position: refs/heads/master@{#465455}

[delete] https://crrev.com/1b1149ae47c1714427323a1d8e13bc0ae4309c1c/device/vibration/OWNERS
[delete] https://crrev.com/1b1149ae47c1714427323a1d8e13bc0ae4309c1c/device/vibration/vibration_export.h
[delete] https://crrev.com/1b1149ae47c1714427323a1d8e13bc0ae4309c1c/device/vibration/vibration_manager_impl.h
[modify] https://crrev.com/619fa1b9313edde43a21f0506e6c16f3ba7ee04f/services/device/BUILD.gn
[modify] https://crrev.com/619fa1b9313edde43a21f0506e6c16f3ba7ee04f/services/device/device_service.cc
[modify] https://crrev.com/619fa1b9313edde43a21f0506e6c16f3ba7ee04f/services/device/device_service.h
[modify] https://crrev.com/619fa1b9313edde43a21f0506e6c16f3ba7ee04f/services/device/public/interfaces/BUILD.gn
[rename] https://crrev.com/619fa1b9313edde43a21f0506e6c16f3ba7ee04f/services/device/public/interfaces/vibration_manager.mojom
[rename] https://crrev.com/619fa1b9313edde43a21f0506e6c16f3ba7ee04f/services/device/vibration/BUILD.gn
[add] https://crrev.com/619fa1b9313edde43a21f0506e6c16f3ba7ee04f/services/device/vibration/OWNERS
[rename] https://crrev.com/619fa1b9313edde43a21f0506e6c16f3ba7ee04f/services/device/vibration/android/BUILD.gn
[rename] https://crrev.com/619fa1b9313edde43a21f0506e6c16f3ba7ee04f/services/device/vibration/android/java/src/org/chromium/device/vibration/VibrationManagerImpl.java
[add] https://crrev.com/619fa1b9313edde43a21f0506e6c16f3ba7ee04f/services/device/vibration/vibration_manager_impl.h
[rename] https://crrev.com/619fa1b9313edde43a21f0506e6c16f3ba7ee04f/services/device/vibration/vibration_manager_impl_default.cc
[modify] https://crrev.com/619fa1b9313edde43a21f0506e6c16f3ba7ee04f/services/device/vibration/vibration_manager_impl_unittest.cc
[modify] https://crrev.com/619fa1b9313edde43a21f0506e6c16f3ba7ee04f/third_party/WebKit/LayoutTests/vibration/resources/vibration-helpers.js
[modify] https://crrev.com/619fa1b9313edde43a21f0506e6c16f3ba7ee04f/third_party/WebKit/Source/modules/notifications/BUILD.gn
[modify] https://crrev.com/619fa1b9313edde43a21f0506e6c16f3ba7ee04f/third_party/WebKit/Source/modules/vibration/BUILD.gn
[modify] https://crrev.com/619fa1b9313edde43a21f0506e6c16f3ba7ee04f/third_party/WebKit/Source/modules/vibration/DEPS
[modify] https://crrev.com/619fa1b9313edde43a21f0506e6c16f3ba7ee04f/third_party/WebKit/Source/modules/vibration/VibrationController.h

Comment 4 by leon....@intel.com, Apr 26 2017

Status: Fixed (was: Available)

Comment 5 by blundell@chromium.org, Nov 7 2017

Components: Internals>Services>Device
►

Sign in to add a comment