New issue
Advanced search Search tips

Issue 686687 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocked on:
issue 686692
issue 689385

Blocking:
issue 686693



Sign in to add a comment

Device Service: Port Vibration Mojo interface from being hosted in //content/browser to being hosted in the Device Service

Project Member Reported by blundell@chromium.org, Jan 30 2017

Issue description

As part of the Content Modularization Project, the Vibration Mojo interface should be extracted from being hosted by //content/browser into being hosted in the Device Service.
 
 
Note that as part of (or immediately after) the port of the hosting, the Mojo interfaces themselves should be moved from //device/vibration to //services/device/public/interfaces.
Blockedon: 686692
Blocking: 686693

Comment 4 by leon....@intel.com, Feb 15 2017

Owner: leon....@intel.com

Comment 5 by leon....@intel.com, Feb 16 2017

To register our VibrationManager interface implemented purely in Java, need to leverage services/device/android/java/src/org/chromium/services/device/InterfaceRegistrar.java created by this CL https://codereview.chromium.org/2643713002/.

Comment 6 by leon....@intel.com, Mar 17 2017

Blockedon: 689385
As https://codereview.chromium.org/2731953003/ added some vibration layout tests which need injecting mock VibrationManager, now this issue gets a new dependency: 689385 

Comment 7 by leon....@intel.com, Mar 17 2017

Status: Started (was: Available)
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/235ea3af87ab499c13c04634c7311da9fe79a1fb

commit 235ea3af87ab499c13c04634c7311da9fe79a1fb
Author: leon.han <leon.han@intel.com>
Date: Fri Mar 24 06:17:29 2017

[DeviceService] Port VibrationManager to be hosted in Device Service

This CL ports VibrationManager from being hosted in //content/browser/
to be hosted in Device Service, and revises vibration layout tests
accorddingly.

BUG= 686687 
TEST=blink_tests
TBR=mvanouwerkerk@chromium.org
  for changes of device/vibration/BUILD.gn
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2755363002
Cr-Commit-Position: refs/heads/master@{#459370}

[modify] https://crrev.com/235ea3af87ab499c13c04634c7311da9fe79a1fb/content/app/BUILD.gn
[modify] https://crrev.com/235ea3af87ab499c13c04634c7311da9fe79a1fb/content/app/DEPS
[modify] https://crrev.com/235ea3af87ab499c13c04634c7311da9fe79a1fb/content/browser/BUILD.gn
[modify] https://crrev.com/235ea3af87ab499c13c04634c7311da9fe79a1fb/content/browser/DEPS
[modify] https://crrev.com/235ea3af87ab499c13c04634c7311da9fe79a1fb/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/235ea3af87ab499c13c04634c7311da9fe79a1fb/content/public/android/BUILD.gn
[modify] https://crrev.com/235ea3af87ab499c13c04634c7311da9fe79a1fb/content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrarImpl.java
[modify] https://crrev.com/235ea3af87ab499c13c04634c7311da9fe79a1fb/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/235ea3af87ab499c13c04634c7311da9fe79a1fb/content/public/app/mojo/content_renderer_manifest.json
[modify] https://crrev.com/235ea3af87ab499c13c04634c7311da9fe79a1fb/content/renderer/BUILD.gn
[modify] https://crrev.com/235ea3af87ab499c13c04634c7311da9fe79a1fb/content/renderer/DEPS
[modify] https://crrev.com/235ea3af87ab499c13c04634c7311da9fe79a1fb/device/vibration/BUILD.gn
[modify] https://crrev.com/235ea3af87ab499c13c04634c7311da9fe79a1fb/services/device/BUILD.gn
[modify] https://crrev.com/235ea3af87ab499c13c04634c7311da9fe79a1fb/services/device/android/java/src/org/chromium/services/device/InterfaceRegistrar.java
[modify] https://crrev.com/235ea3af87ab499c13c04634c7311da9fe79a1fb/services/device/device_service.cc
[modify] https://crrev.com/235ea3af87ab499c13c04634c7311da9fe79a1fb/services/device/device_service.h
[modify] https://crrev.com/235ea3af87ab499c13c04634c7311da9fe79a1fb/services/device/manifest.json
[modify] https://crrev.com/235ea3af87ab499c13c04634c7311da9fe79a1fb/third_party/WebKit/LayoutTests/vibration/resources/vibrate-from-iframe.html
[modify] https://crrev.com/235ea3af87ab499c13c04634c7311da9fe79a1fb/third_party/WebKit/LayoutTests/vibration/resources/vibration-helpers.js
[modify] https://crrev.com/235ea3af87ab499c13c04634c7311da9fe79a1fb/third_party/WebKit/LayoutTests/vibration/vibration-iframe.html
[modify] https://crrev.com/235ea3af87ab499c13c04634c7311da9fe79a1fb/third_party/WebKit/Source/modules/vibration/BUILD.gn
[modify] https://crrev.com/235ea3af87ab499c13c04634c7311da9fe79a1fb/third_party/WebKit/Source/modules/vibration/DEPS
[modify] https://crrev.com/235ea3af87ab499c13c04634c7311da9fe79a1fb/third_party/WebKit/Source/modules/vibration/VibrationController.cpp
[modify] https://crrev.com/235ea3af87ab499c13c04634c7311da9fe79a1fb/third_party/WebKit/Source/modules/vibration/VibrationController.h

Comment 9 by leon....@intel.com, Mar 24 2017

Status: Fixed (was: Started)
Components: Internals>Services>Device
Labels: Type-Task
Migrating S13N meta bugs to Type=Task, so that they can be distinguished from technical work.

Sign in to add a comment