Issue metadata
Sign in to add a comment
|
1% regression in webrtc_perf_tests at 16138:16138 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jan 30 2017
nisse@: This regression seems to possibly be related to your CL https://codereview.webrtc.org/2633673002. Could you please take a look?
,
Jan 30 2017
Seems likely it's my change. But I think it can be considered an improvement, since measurements get less noisy. I don't think my cl changes the actual encoder performance, only the way it's measured. Was this visible on mac only?
,
Jan 31 2017
I think so. But there has been some recent other regressions that have been related to H264. Do you know anything about recent changes in that code?
,
Jan 31 2017
No, I haven't worked with anything h.264 specific.
,
Jan 31 2017
hta@: You had a CL regarding H264 code updates recently. Do you know of any recent H264 code changes that could have caused this regression?
,
Jan 31 2017
hta@: You had a CL regarding H264 code updates recently. Do you know of any recent H264 code changes that could have caused this regression?
,
Jan 31 2017
None of the recent H.264 changes touched Mac (it's explicitly excluded from the H.264 assembly fixes). Assigning back to nisse@.
,
Feb 1 2017
Closing. I think this actually is an improvement in the measurement of encode time, with slightly less noise. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by peah@chromium.org
, Jan 30 2017