New issue
Advanced search Search tips

Issue 686661 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1% regression in webrtc_perf_tests at 16138:16138

Project Member Reported by peah@chromium.org, Jan 30 2017

Issue description

See the link to graphs below.
 

Comment 1 by peah@chromium.org, Jan 30 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=686661

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgkMvougoM


Bot(s) for this bug's original alert(s):

webrtc-mac-large-tests

Comment 2 by peah@chromium.org, Jan 30 2017

Owner: nisse@chromium.org
nisse@: This regression seems to possibly be related to your CL https://codereview.webrtc.org/2633673002. Could you please take a look?

Comment 3 by nisse@chromium.org, Jan 30 2017

Seems likely it's my change. But I think it can be considered an improvement, since measurements get less noisy. I don't think my cl changes the actual encoder performance, only the way it's measured.

Was this visible on mac only?

Comment 4 by peah@chromium.org, Jan 31 2017

I think so. But there has been some recent other regressions that have been related to H264. Do you know anything about recent changes in that code?

Comment 5 by nisse@chromium.org, Jan 31 2017

No, I haven't worked with anything h.264 specific.

Comment 6 by peah@chromium.org, Jan 31 2017

Owner: hta@chromium.org
hta@: You had a CL regarding H264 code updates recently. Do you know of any recent H264 code changes that could have caused this regression?

Comment 7 by peah@chromium.org, Jan 31 2017

hta@: You had a CL regarding H264 code updates recently. Do you know of any recent H264 code changes that could have caused this regression?

Comment 8 by hta@chromium.org, Jan 31 2017

Cc: hta@chromium.org
Owner: nisse@chromium.org
None of the recent H.264 changes touched Mac (it's explicitly excluded from the H.264 assembly fixes). Assigning back to nisse@.

Comment 9 by nisse@chromium.org, Feb 1 2017

Status: WontFix (was: Assigned)
Closing. I think this actually is an improvement in the measurement of encode time, with slightly less noise.

Sign in to add a comment