New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 686645 link

Starred by 4 users
Status: Fixed
Owner:
grt@chromium.org
Closed: Jan 2017
Cc:
█ bustamante@chromium.org
waff...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Error 0x80040902: 50 when updating to Chrome 56 via chrome://help

Project Member Reported by grt@chromium.org, Jan 30 2017 
To reproduce:
- install M55 multi-install
- delete ...\Chrome\Application\55.0.2883.87\Installer\chrome.7z
- visit chrome://help to update to M56
- see error 0x80040902: 50
- refresh
- see error 0x80040902: 50 again

Error 50 is DIFF_PATCH_SOURCE_MISSING, which means chrome.7z couldn't be found to apply the delta update. The next update should fallback to the full installer, but it isn't. This is because the mini_installer is only appending the "-full" tidbit to Chrome's "ap" value and not the binaries'.

This is already fixed in M57 by r438644.

This bug breaks all diff->full fallback scenarios in M56 (successful diff updates work properly). I'll get started on a fix we can merge to M56 for a refresh.

Comment 1 by grt@chromium.org, Jan 30 2017 

Anyone impacted with this can perform a "repair install" by visiting https://www.google.com/chrome/browser/desktop/index.html and downloading a new installer. You don't even need to quit Chrome for this -- just let the installer run. When it's finished, chrome://help should report that a restart is needed. Once you restart Chrome, you should be all set.

Comment 2 by grt@chromium.org, Jan 31 2017

Labels: Merge-Request-56
Status: Fixed (was: Started)
I have prepared https://codereview.chromium.org/2663003003/, which is a hand-crafted partial merge of r438644. Proactively requesting a merge now while the CL is out for review. Local tests show that it's doing the right thing. Thanks.
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 31 2017

Labels: -Merge-Request-56 Merge-Review-56 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by bustamante@google.com, Jan 31 2017

Labels: -Merge-Review-56 Merge-Approved-56
Approving for merge into M56 per offline discussion.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 31 2017

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f55b083a84bb3fc58852c6d767f1ccdedcadee3

commit 7f55b083a84bb3fc58852c6d767f1ccdedcadee3
Author: grt <grt@chromium.org>
Date: Tue Jan 31 19:48:56 2017

Fix -full fallback for diff updates (M56).

mini_installer will now report state properly regardless of whether
updates are being delivered via Chrome's or the binaries' app guid:
- "-full" is added to Chrome's "ap" value and, in case an existing
  multi-install Chrome is being updated, the binaries' "ap" value.
- Installer results are written to Chrome's ClientState key and, as
  above, the binaries'.

This is a partial merge of r438644.

BUG= 686645 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2663003003
Cr-Commit-Position: refs/branch-heads/2924@{#889}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/7f55b083a84bb3fc58852c6d767f1ccdedcadee3/chrome/installer/mini_installer/BUILD.gn
[modify] https://crrev.com/7f55b083a84bb3fc58852c6d767f1ccdedcadee3/chrome/installer/mini_installer/configuration.cc
[modify] https://crrev.com/7f55b083a84bb3fc58852c6d767f1ccdedcadee3/chrome/installer/mini_installer/configuration.h
[modify] https://crrev.com/7f55b083a84bb3fc58852c6d767f1ccdedcadee3/chrome/installer/mini_installer/configuration_test.cc
[modify] https://crrev.com/7f55b083a84bb3fc58852c6d767f1ccdedcadee3/chrome/installer/mini_installer/mini_installer.cc
[modify] https://crrev.com/7f55b083a84bb3fc58852c6d767f1ccdedcadee3/chrome/installer/mini_installer/mini_installer_constants.cc
[modify] https://crrev.com/7f55b083a84bb3fc58852c6d767f1ccdedcadee3/chrome/installer/mini_installer/mini_installer_constants.h
[modify] https://crrev.com/7f55b083a84bb3fc58852c6d767f1ccdedcadee3/chrome/installer/mini_installer/regkey.cc
[modify] https://crrev.com/7f55b083a84bb3fc58852c6d767f1ccdedcadee3/chrome/installer/mini_installer/regkey.h

Comment 6 by grt@chromium.org, Feb 1 2017 

I've just run a number of manual tests with 56.0.2924.86. All seems well.
►

Sign in to add a comment