New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 686638 link

Starred by 2 users
Status: Fixed
Owner:
█ lushnikov@chromium.org
Last visit 29 days ago
Closed: Feb 2017
Cc:
█ hdodda@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: 'Remove' icon of Throttling does not get highlighted after hovering mouse on it

Reported by jshan...@etouch.net, Jan 30 2017 
Chrome Version: 58.0.2997.0 (Official Build) b84d9d8be2e7f07b9e53e8d6243b7d41557fd77c-refs/heads/master@{#446949}- 32/64 bit
OS : Mac(10.12.1, 10.11.6, 10.12), Windows(7,8,10), Linux 14.04

Steps:
1. Launch Chrome and open devtools on NTP, press F1 to open Settings on devtools
2. Go to Throttling, Click on 'Add custom profile' button and add any profile name 
3. Hover mouse on 'Remove' icon of added profile and observe.

Actual: 'Remove' icon does not get highlighted after hovering mouse on it

Expected: 'Remove' icon should get highlighted after hovering mouse on it

This is a regression issue broken in M-58, will soon update other info.

Good build : 58.0.2993.0
Bad build : 58.0.2994.0

Comment 1 by rbasuvula@chromium.org, Jan 30 2017

Cc: rbasuvula@chromium.org
Labels: ReleaseBlock-Stable hasbisect-per-revison
Owner: lushnikov@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 58.0.2993.0 (Revision: 446204).
Bad build: 58.0.2994.0 (Revision: 446546).

You are probably looking for a change made after 446251 (known good), but no later than 446252 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/0dca64e43351279355d64d5d612e33d388d583d5..6e9b9e99c6b3373d611d81d83f431fdbba9bf04f

From the CL above, assigning the issue to the concern owner

@lushnikov: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2652173002

Note : Able to reproduce the issue in Win 7,mac 10.12.2 &Ubuntu 14.04.

Adding Release Block-Stable for this issue.Please undo if not the case.

Comment 2 by jshan...@etouch.net, Jan 30 2017

Actual_Expected_result.jpg
76.6 KB View Download

Comment 3 by ajha@chromium.org, Feb 1 2017 

Gentle ping to get an update on this.

Comment 4 by hdodda@chromium.org, Feb 9 2017

Cc: hdodda@chromium.org
Issue still exists on mac os 10.12.2 in chrome canary M58 #58.0.3007.0 .

@lushnikov-- Could you please look into this issue .

Thanks!

Comment 5 by lushnikov@chromium.org, Feb 10 2017

Status: Started (was: Assigned)
started: https://codereview.chromium.org/2688153003/#
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0770a61ad8dc130e4adecae097fe73c9b6827789

commit 0770a61ad8dc130e4adecae097fe73c9b6827789
Author: lushnikov <lushnikov@chromium.org>
Date: Sat Feb 11 02:23:26 2017

DevTools: fix blackboxing buttons

This patch converts icons in ListWidget to toolbar, which solves a lot
of styling issues and adds support to dark theme.

BUG= 686638 
R=pfeldman

Review-Url: https://codereview.chromium.org/2688153003
Cr-Commit-Position: refs/heads/master@{#449835}

[modify] https://crrev.com/0770a61ad8dc130e4adecae097fe73c9b6827789/third_party/WebKit/Source/devtools/front_end/ui/Icon.js
[modify] https://crrev.com/0770a61ad8dc130e4adecae097fe73c9b6827789/third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js
[modify] https://crrev.com/0770a61ad8dc130e4adecae097fe73c9b6827789/third_party/WebKit/Source/devtools/front_end/ui/listWidget.css

Comment 7 by msrchandra@chromium.org, Feb 14 2017

Labels: TE-Verified-M58 TE-Verified-58.0.3012.0
Tested the issue on Latest Dev# 58.0.3012.0 on Windows, Mac and Linux and found the issue is not reproducible.
Attaching screenshot for reference. Hence adding TE-Verified Labels.
Thank You.
686638.png
137 KB View Download

Comment 8 by lushnikov@chromium.org, Feb 14 2017

Status: Fixed (was: Started)
►

Sign in to add a comment