New issue
Advanced search Search tips

Issue 686632 link

Starred by 2 users
Status: Fixed
Owner:
zhongyi@chromium.org
Closed: Feb 2017
Cc:
rch@chromium.org
mmenke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 686631


Sign in to add a comment

Make sure QuicServerInfoFactoryAdaptor is set up with the right HttpCache

Project Member Reported by zhongyi@chromium.org, Jan 30 2017 
QuicServerInfoFactoryAdaptor is currently set up to the HttpNetworkSession on the creation of HttpCache if no one has been set up before and will be accessing the HttpCache created. However, multiple HttpCache objects (normal and media caches) could share the same HttpNetworkSession, thus changing the order of HttpCache creations would change the HttpCache that QuicServerInfoFactoryAdaptor is accessing, which might cause the server info be ignored on different startups. 

Current code works as the creation of the HttpCache is deterministic. Need a fix to the code so that server info data is always persisted to a specific cache.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4928bd5160bb22433aff3dc42d2c2773e4f09b9f

commit 4928bd5160bb22433aff3dc42d2c2773e4f09b9f
Author: zhongyi <zhongyi@chromium.org>
Date: Wed Feb 08 02:16:27 2017

Rename set_up_quic_server_info_factory to is_main_cache in HttpCache constructor
so that future settings could be bundled with the same boolean.

BUG= 686632 

Review-Url: https://codereview.chromium.org/2681953002
Cr-Commit-Position: refs/heads/master@{#448859}

[modify] https://crrev.com/4928bd5160bb22433aff3dc42d2c2773e4f09b9f/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/4928bd5160bb22433aff3dc42d2c2773e4f09b9f/content/shell/browser/shell_url_request_context_getter.cc
[modify] https://crrev.com/4928bd5160bb22433aff3dc42d2c2773e4f09b9f/net/cert_net/cert_net_fetcher_impl_unittest.cc
[modify] https://crrev.com/4928bd5160bb22433aff3dc42d2c2773e4f09b9f/net/http/http_cache.cc
[modify] https://crrev.com/4928bd5160bb22433aff3dc42d2c2773e4f09b9f/net/http/http_cache.h
[modify] https://crrev.com/4928bd5160bb22433aff3dc42d2c2773e4f09b9f/net/http/mock_http_cache.cc
[modify] https://crrev.com/4928bd5160bb22433aff3dc42d2c2773e4f09b9f/net/http/mock_http_cache.h
[modify] https://crrev.com/4928bd5160bb22433aff3dc42d2c2773e4f09b9f/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/4928bd5160bb22433aff3dc42d2c2773e4f09b9f/net/url_request/view_cache_helper_unittest.cc

Comment 5 by zhongyi@chromium.org, Feb 8 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment