New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 686590 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ServiceWorkerPageLoadMetricsObserverTest.WithServiceWorkerBackground not triggering NavigationToParseStart.Background histogram

Project Member Reported by bmcquade@chromium.org, Jan 29 2017

Issue description

On the Win7 Tests (dbg)(1) builder, we see the WithServiceWorkerBackground test failing as a result of landing https://codereview.chromium.org/2651883006. The error message shows:

[ RUN      ] ServiceWorkerPageLoadMetricsObserverTest.WithServiceWorkerBackground
c:\c\win\srcase	est\histogram_tester.cc(72): error: Value of: 0
Expected: count
Which is: 1
Histogram "PageLoad.Clients.ServiceWorker.ParseTiming.NavigationToParseStart.Background" does not exist.
[  FAILED  ] ServiceWorkerPageLoadMetricsObserverTest.WithServiceWorkerBackground (357 ms)

We'll disable the failing part of the test for now,  but should debug and fix the root cause in a follow up change.
 
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a006f6773bd972507244e9ad74dab7471bff6b7

commit 5a006f6773bd972507244e9ad74dab7471bff6b7
Author: bmcquade <bmcquade@chromium.org>
Date: Sun Jan 29 23:21:01 2017

Disable assertion failing on Win7 test dbg builder.

BUG=686590
TBR=csharrison

Review-Url: https://codereview.chromium.org/2659293002
Cr-Commit-Position: refs/heads/master@{#446948}

[modify] https://crrev.com/5a006f6773bd972507244e9ad74dab7471bff6b7/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc

Comment 3 by tkent@chromium.org, Jan 30 2017

Components: Blink>ServiceWorker

Sign in to add a comment