Independent fast path for generating CSSProperties causes regression |
|||||||
Issue descriptionAs part of generating computed style, when a property is specified to be independent, some extra inheritance fast path code is generated. However, specifying text-align as independent caused some regressions: - https://bugs.chromium.org/p/chromium/issues/detail?id=680070 - https://bugs.chromium.org/p/chromium/issues/detail?id=680009 We need to investigate why these issues are occurring. Until this is resolved, we should not convert any more properties to independent.
,
Jan 31 2017
Assigning kevin who's looking into independent fast paths.
,
Jan 31 2017
Assigning to napper@ who has reverted crrev.com/2628503002 to solve this
,
Jan 31 2017
+rune who has investigated some of these problems before
,
Feb 12 2017
,
Feb 27 2017
The original CL missed clearing the inherited bit in a custom function. New attempt here: https://codereview.chromium.org/2715213003/
,
Feb 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21ca7c7f71295c31a418e6dfe5dc03148e7bb9b9 commit 21ca7c7f71295c31a418e6dfe5dc03148e7bb9b9 Author: rune <rune@opera.com> Date: Tue Feb 28 01:06:47 2017 Use independent property inheritance fast-path for text-align. This was originally attempted in [1], but the custom function for applying text-align values did not clear the inherited bit. Added a test to the framework to catch the case for trying to propagate a value down to a descendant with the property explicitly set. [1] https://codereview.chromium.org/2628503002/ R=sashab@chromium.org,napper@chromium.org BUG= 628043 , 686585 Review-Url: https://codereview.chromium.org/2715213003 Cr-Commit-Position: refs/heads/master@{#453430} [modify] https://crrev.com/21ca7c7f71295c31a418e6dfe5dc03148e7bb9b9/third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html [modify] https://crrev.com/21ca7c7f71295c31a418e6dfe5dc03148e7bb9b9/third_party/WebKit/Source/core/css/CSSProperties.json5 [modify] https://crrev.com/21ca7c7f71295c31a418e6dfe5dc03148e7bb9b9/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
,
Feb 28 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by shend@chromium.org
, Jan 29 2017