New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 686473 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug-Regression

Blocking:
issue 780164



Sign in to add a comment

Extension path is not shown on chrome://extensions in Material Design

Reported by nn1436...@gmail.com, Jan 28 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:51.0) Gecko/20100101 Firefox/51.0

Steps to reproduce the problem:
1. Enable the experimental flags for material design and specifically the material design extensions flag.
2. Open chrome://extensions
3. Load any unpacked extension
4. Switch to developer mode
5. Path is not shown

What is the expected behavior?
Show path as chrome://extensions does.

What went wrong?
Hard to develop extensions using extensions material design.

Did this work before? Yes 56

Chrome version: 56  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 24.0 r0
 
Labels: Needs-Bisect Needs-Triage-M56
Cc: krajshree@chromium.org
Components: Platform>Extensions
Labels: Needs-Feedback
Unable to reproduce the issue on Win-10 using chrome reported version #56.0.2924.76 and latest canary #58.0.2996.0.

Attached a screen cast for reference.

Following are the steps followed to reproduce the issue.
------------
1. Enabled the experimental flags for material design i.e md-settings.
2. Opened chrome://extensions
3. Loaded a test unpacked extension
4. Switched to developer mode
5. Path is shown as expected.

Reporter@ - Could you please check this issue on latest canary #58.0.2996.0 by creating a new profile and please let us know if the issue still persist or not.

Thanks...!!

686473.mp4
2.0 MB View Download

Comment 3 by woxxom@gmail.com, Jan 30 2017

#2, the bug report is about MD extensions page but you haven't enabled the Material Design extensions flag. It's on chrome://flags page two rows below the one you wiggled.
Labels: -Needs-Bisect

Comment 5 by dpa...@chromium.org, Nov 13 2017

Cc: dschuyler@chromium.org bettes@chromium.org
Components: -UI -Platform>Extensions UI>Browser>ExtensionsManagement
Labels: OS-Chrome OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Let's double check with @bettes whether this is intentional, or just an oversight.
unpacked_location_shown.png
28.7 KB View Download
unpacked_location_not_shown.png
18.9 KB View Download

Comment 6 by woxxom@gmail.com, Nov 13 2017

That's an obvious oversight or still work-in-progress because the path of a locally loaded unpacked extension isn't shown even in Details. OTOH might be intentional... I wouldn't be surprised having seen console.info() effectively killed by Chromium team for no valid reason.
This seems like a good candidate for the Details view.

Comment 8 by dpa...@chromium.org, Nov 14 2017

Blocking: 780164
Status: Available (was: Untriaged)

Comment 9 by dpa...@chromium.org, Nov 14 2017

Owner: dpa...@chromium.org
Status: Stared (was: Available)
CL in progress at https://chromium-review.googlesource.com/#/c/chromium/src/+/769149 (see screenshot). Will add some tests before sending out.
unpacked_load_path.png
23.1 KB View Download
Status: Started (was: stared)
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b0d797f9df885ff7e127cb5937dc8ed81e39f7e

commit 8b0d797f9df885ff7e127cb5937dc8ed81e39f7e
Author: dpapad <dpapad@chromium.org>
Date: Thu Nov 16 03:51:10 2017

MD Extensions: Show load path for unpacked extensions.

Bug:  686473 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I28055c385165b29426e40ddbb8e6941ffa46659c
Reviewed-on: https://chromium-review.googlesource.com/769149
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516977}
[modify] https://crrev.com/8b0d797f9df885ff7e127cb5937dc8ed81e39f7e/chrome/browser/resources/md_extensions/detail_view.html
[modify] https://crrev.com/8b0d797f9df885ff7e127cb5937dc8ed81e39f7e/chrome/browser/resources/md_extensions/detail_view.js
[modify] https://crrev.com/8b0d797f9df885ff7e127cb5937dc8ed81e39f7e/chrome/browser/resources/md_extensions/item.js
[modify] https://crrev.com/8b0d797f9df885ff7e127cb5937dc8ed81e39f7e/chrome/browser/resources/md_extensions/service.js
[modify] https://crrev.com/8b0d797f9df885ff7e127cb5937dc8ed81e39f7e/chrome/browser/ui/webui/extensions/extensions_ui.cc
[modify] https://crrev.com/8b0d797f9df885ff7e127cb5937dc8ed81e39f7e/chrome/test/data/webui/extensions/extension_detail_view_test.js
[modify] https://crrev.com/8b0d797f9df885ff7e127cb5937dc8ed81e39f7e/chrome/test/data/webui/extensions/extension_test_util.js

Status: Fixed (was: Started)

Sign in to add a comment