New issue
Advanced search Search tips

Issue 686470 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Console messages in http/tests/security/xss-DENIED-window-name-navigator.html have non-deterministic order

Project Member Reported by qyears...@chromium.org, Jan 28 2017

Issue description

I think it appears that the order of console messages in this test can change, causing the test to fail. Example failures due to console message order difference:

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7/49930/layout-test-results/results.html

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7__dbg_/8856/layout-test-results/results.html
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89b52701a2335cf1fbcffcae15ae1621630680a3

commit 89b52701a2335cf1fbcffcae15ae1621630680a3
Author: qyearsley <qyearsley@chromium.org>
Date: Sat Jan 28 22:08:09 2017

Add flaky test expectation for http/tests/security/xss-DENIED-window-name-navigator.html.

TBR=yukishiino
TBR_REASON=Updating expectations to make Blink Win continuous builders green again
BUG= 686470 , 685851 

Review-Url: https://codereview.chromium.org/2664503005
Cr-Commit-Position: refs/heads/master@{#446924}

[modify] https://crrev.com/89b52701a2335cf1fbcffcae15ae1621630680a3/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0b3e8c6b218579d8145366394bd33faad52e875

commit a0b3e8c6b218579d8145366394bd33faad52e875
Author: qyearsley <qyearsley@chromium.org>
Date: Sun Jan 29 03:42:30 2017

Remove OS specifier from ".../xss-DENIED-window-name-navigator.html"

This is a follow-up to https://codereview.chromium.org/2664503005.

Looks like this test is also flak on other platforms:
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_11__retina_/11643/layout-test-results/results.html.

TBR=yukishiino
TBR_REASON=Updating expectations to make continuous builders green again
BUG= 686470 , 685851 

Review-Url: https://codereview.chromium.org/2665573002
Cr-Commit-Position: refs/heads/master@{#446933}

[modify] https://crrev.com/a0b3e8c6b218579d8145366394bd33faad52e875/third_party/WebKit/LayoutTests/TestExpectations

Status: Assigned (was: Unconfirmed)
Cc: yukishiino@chromium.org
 Issue 685958  has been merged into this issue.
Status: Started (was: Assigned)
Components: Blink>Bindings
Status: Fixed (was: Started)
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dde6e8dff66e9a76131efe6e1f27779ca8abc867

commit dde6e8dff66e9a76131efe6e1f27779ca8abc867
Author: joedow <joedow@chromium.org>
Date: Fri Feb 03 18:04:11 2017

Revert of binding: Makes xss-DENIED-window-name-navigator deterministic. (patchset #2 id:20001 of https://codereview.chromium.org/2673583003/ )

Reason for revert:
Builds on https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29 have been consistently failing since this CL was landed.  Reverting for that reason.

Original issue's description:
> binding: Makes xss-DENIED-window-name-navigator deterministic.
>
> Makes the test result of xss-DENIED-window-name-navigator.html
> deterministic and fixes the flakiness.
>
> BUG= 686470 
>
> Review-Url: https://codereview.chromium.org/2673583003
> Cr-Commit-Position: refs/heads/master@{#447958}
> Committed: https://chromium.googlesource.com/chromium/src/+/114e65b6ddfd281fadd15c8ee43894b40b984b91

TBR=haraken@chromium.org,yukishiino@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 686470 

Review-Url: https://codereview.chromium.org/2673833004
Cr-Commit-Position: refs/heads/master@{#448021}

[modify] https://crrev.com/dde6e8dff66e9a76131efe6e1f27779ca8abc867/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/dde6e8dff66e9a76131efe6e1f27779ca8abc867/third_party/WebKit/LayoutTests/http/tests/security/xss-DENIED-window-name-navigator-expected.txt
[modify] https://crrev.com/dde6e8dff66e9a76131efe6e1f27779ca8abc867/third_party/WebKit/LayoutTests/http/tests/security/xss-DENIED-window-name-navigator.html
[add] https://crrev.com/dde6e8dff66e9a76131efe6e1f27779ca8abc867/third_party/WebKit/LayoutTests/platform/mac/http/tests/security/xss-DENIED-window-name-navigator-expected.txt

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 10 2017

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fff67c6c52d925d712d09b0674142f85c18a0a5f

commit fff67c6c52d925d712d09b0674142f85c18a0a5f
Author: yukishiino <yukishiino@chromium.org>
Date: Mon Apr 17 13:52:17 2017

v8binding: Updates results of xss-DENIED-window-name-navigator.

Due to the revert at https://crrev.com/2753773003 , this CL
updates the test result before re-enabling the test.

BUG= 686470 

Review-Url: https://codereview.chromium.org/2824753002
Cr-Commit-Position: refs/heads/master@{#464919}

[modify] https://crrev.com/fff67c6c52d925d712d09b0674142f85c18a0a5f/third_party/WebKit/LayoutTests/http/tests/security/xss-DENIED-window-name-navigator-expected.txt

Project Member

Comment 13 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/011220664d3be6c6ab847371f5d5863813c321fd

commit 011220664d3be6c6ab847371f5d5863813c321fd
Author: yukishiino <yukishiino@chromium.org>
Date: Tue Apr 18 07:14:36 2017

v8binding: Reenable xss-DENIED-window-name-navigator test.

Enables xss-DENIED-window-name-navigator test again since
https://crrev.com/2800053003 and https://crrev.com/2824753002
should have fixed the flakiness.

BUG= 686470 

Review-Url: https://codereview.chromium.org/2818423002
Cr-Commit-Position: refs/heads/master@{#465166}

[modify] https://crrev.com/011220664d3be6c6ab847371f5d5863813c321fd/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 14 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32c7f299bac9dfc90dcdbc2a9273892f01ce18e6

commit 32c7f299bac9dfc90dcdbc2a9273892f01ce18e6
Author: ojan <ojan@chromium.org>
Date: Tue Apr 18 19:04:48 2017

Revert of v8binding: Reenable xss-DENIED-window-name-navigator test. (patchset #1 id:1 of https://codereview.chromium.org/2818423002/ )

Reason for revert:
virtual/mojo-loading/http/tests/security/xss-DENIED-window-name-navigator.html still fails on the retina bot, but it's not flaky at least. :)

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fmojo-loading%2Fhttp%2Ftests%2Fsecurity%2Fxss-DENIED-window-name-navigator.html&testType=webkit_tests

Original issue's description:
> v8binding: Reenable xss-DENIED-window-name-navigator test.
>
> Enables xss-DENIED-window-name-navigator test again since
> https://crrev.com/2800053003 and https://crrev.com/2824753002
> should have fixed the flakiness.
>
> BUG= 686470 
>
> Review-Url: https://codereview.chromium.org/2818423002
> Cr-Commit-Position: refs/heads/master@{#465166}
> Committed: https://chromium.googlesource.com/chromium/src/+/011220664d3be6c6ab847371f5d5863813c321fd

TBR=haraken@chromium.org,yukishiino@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 686470 

Review-Url: https://codereview.chromium.org/2820103008
Cr-Commit-Position: refs/heads/master@{#465314}

[modify] https://crrev.com/32c7f299bac9dfc90dcdbc2a9273892f01ce18e6/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 15 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ea14ae14aa944a93b46bb888c1aa21261ea3c62

commit 0ea14ae14aa944a93b46bb888c1aa21261ea3c62
Author: yukishiino <yukishiino@chromium.org>
Date: Fri Apr 21 10:58:49 2017

v8binding: Removes an unnecessary expectation file of a LayoutTest.

http/tests/security/xss-DENIED-window-name-navigator.html has no
behavior specific to mac-retina + mojo-loading.
LayoutTests/platform/mac-retina/virtual/mojo-loading/http/tests/security/xss-DENIED-window-name-navigator-expected.txt
is simply unnecessary.

BUG= 686470 

Review-Url: https://codereview.chromium.org/2835603004
Cr-Commit-Position: refs/heads/master@{#466310}

[delete] https://crrev.com/c0f93a9a83297a1046670164881e6bd0ce2b66d6/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/mojo-loading/http/tests/security/xss-DENIED-window-name-navigator-expected.txt

Project Member

Comment 16 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f773b98bf5c144b8ff81320023e548b6930f40d

commit 2f773b98bf5c144b8ff81320023e548b6930f40d
Author: yukishiino <yukishiino@chromium.org>
Date: Tue Apr 25 10:11:58 2017

v8binding: Enables xss-DENIED-window-name-navigator.

Enables xss-DENIED-window-name-navigator test again since
https://crrev.com/2800053003 and https://crrev.com/2824753002
should have fixed the flakiness.

https://crrev.com/2835603004 should have solved the cause of
the previous revert.

BUG= 686470 

Review-Url: https://codereview.chromium.org/2833073003
Cr-Commit-Position: refs/heads/master@{#466938}

[modify] https://crrev.com/2f773b98bf5c144b8ff81320023e548b6930f40d/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment