New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 686457 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Disable WebAssembly Structured Cloning.

Project Member Reported by bradnelson@chromium.org, Jan 28 2017

Issue description

As we continue to evaluate the API / Security properties of WebAssembly Structured Cloning, we should move the feature back behind a flag for M57.


 
This has been done on the chrome side in:
https://codereview.chromium.org/2642793003
Labels: Merge-Request-57
We should merge this to M57:
https://chromium.googlesource.com/chromium/src/+/2730e3510753fefbc760b09a3c4d3ace5c585a36
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 29 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 1 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a8532ff79877d6515145c19972efd2d09e58030

commit 2a8532ff79877d6515145c19972efd2d09e58030
Author: Brad Nelson <bradnelson@chromium.org>
Date: Wed Feb 01 19:02:18 2017

[wasm] Change WebAssembly flags option to only cover structured cloning.

Cherry-picked from 2730e3510753fefbc760b09a3c4d3ace5c585a36
https://codereview.chromium.org/2642793003
BUG=686457
BUG=575167

TBR=amineer@chromium.org,cmasso@chromium.org,ketakid@chromium.org,govind@chromium.org

Review-Url: https://codereview.chromium.org/2642793003
Cr-Original-Commit-Position: refs/heads/master@{#445293}
Review-Url: https://codereview.chromium.org/2669843002 .
Cr-Commit-Position: refs/branch-heads/2987@{#249}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/2a8532ff79877d6515145c19972efd2d09e58030/chrome/app/generated_resources.grd
[modify] https://crrev.com/2a8532ff79877d6515145c19972efd2d09e58030/content/child/runtime_features.cc
[modify] https://crrev.com/2a8532ff79877d6515145c19972efd2d09e58030/content/renderer/render_process_impl.cc

Sign in to add a comment