New issue
Advanced search Search tips

Issue 686434 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-buffer-overflow in ps_table_add

Project Member Reported by ClusterFuzz, Jan 28 2017

Issue description

Comment 1 by est...@chromium.org, Jan 28 2017

Cc: thestig@chromium.org
Components: Internals>Plugins>PDF
Owner: dpranke@chromium.org
Status: Assigned (was: Untriaged)
dpranke, can you please take a look? Thanks.
Cc: tsepez@chromium.org drott@chromium.org jam@chromium.org
Owner: ----
Status: Available (was: Assigned)
I suspect this is a PDFium bug (based on the stack trace and the roll in the changelog).

jam@, tsepez@?

Comment 3 by est...@chromium.org, Jan 29 2017

Owner: tsepez@chromium.org
Status: Assigned (was: Available)
Assigning to tsepez for pdfium triage
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 29 2017

Labels: M-56
Project Member

Comment 5 by sheriffbot@chromium.org, Jan 29 2017

Labels: Pri-1

Comment 6 by drott@chromium.org, Jan 30 2017

It looks like it's crashing in FreeType's Type 1 font code. FYI, I am working on linking latest FreeType statically in  issue 274030 .
Project Member

Comment 7 by sheriffbot@chromium.org, Feb 12 2017

tsepez: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by tsepez@chromium.org, Feb 14 2017

Owner: dsinclair@chromium.org
I'm not working on this currently.  To dan.
I'm unable to repro this on my local build. How do I force chrome to use the bundled freetype2 when building?
Project Member

Comment 10 by ClusterFuzz, Feb 28 2017

ClusterFuzz has detected this issue as fixed in range 453200:453220.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6143123739901952

Fuzzer: attekett_surku_fuzzer
Job Type: linux_lsan_chrome_mp
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 7
Crash Address: 0x61b000006890
Crash State:
  ps_table_add
  parse_encoding
  t1_load_keyword
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_lsan_chrome_mp&range=314095:314100
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_lsan_chrome_mp&range=453200:453220

Reproducer Testcase: https://cluster-fuzz.appspot.com/download/AMIfv96KyH9GAOlcXydWdn9aOt40sV9gBfbpfwIWYQAlZmzDl-GwAxu-y9y12LRoIWvmP9uxNmkk1iGv6UqISw2qWAGUTrvOPKffLPW1CkA6J3FwuQUDumNA1PrA1W4tkOFA5P5QThPOuhP1ISa9zo5OODeyoieDj3Dx6YJOYDHRgj91GdJwnmKCpI2Llvp6W9SwM4EfHUpEbFhElS6bOzSCf4KpKTtRiiqI-iV-HJrYiYArNSwehSkTXzAcWeKKstdX94GlxvvYHXODoK1hQeBnKzLWnsND3B7TCiQUQ-LhQspPNhvLKIkoECE0FWHKGLdfk3Xr8pUFZcKkFcOcsOud_U4Vz1RMDSfxF4DijszKKFt8HKpzy_A?testcase_id=6143123739901952


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
The fixed changelog looks suspicious.
Project Member

Comment 12 by ClusterFuzz, Feb 28 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6143123739901952 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Comment 13 by drott@chromium.org, Feb 28 2017

Re #11, why? Most likely the FreeType update to 2.7.1 I did in https://chromium.googlesource.com/chromium/src/+/90d1657ffcf4eb720c60e572453477fad72377f9 fixed this issue.
Project Member

Comment 14 by sheriffbot@chromium.org, Mar 1 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -M-56 M-58
Labels: -reward-topanel reward-0
Project Member

Comment 17 by sheriffbot@chromium.org, Mar 17 2017

Labels: Merge-Request-58
Project Member

Comment 18 by sheriffbot@chromium.org, Mar 18 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 19 by drott@chromium.org, Mar 20 2017

I don't think we want to merge the FreeType 2.7.1 update to M58. The FreeType we use for testing is not something we currently ship in the release version of the browser. 
Cc: -drott@chromium.org dsinclair@chromium.org
Owner: drott@chromium.org
Changing the owner to drott@ as it looks like their fix was the solution.
Project Member

Comment 21 by sheriffbot@chromium.org, Mar 21 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Approved -Merge-Approved-58
Labels: Release-0-M58
Project Member

Comment 24 by sheriffbot@chromium.org, Jun 7 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment