New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 686389 link

Starred by 4 users

Issue metadata

Status: Archived
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature
Launch-Privacy: Yes



Sign in to add a comment

Remote command for Device attributes & logs

Project Member Reported by sduraisamy@chromium.org, Jan 28 2017

Issue description

FR: Design a remote command to fetch device attributes including audio settings. This will enable Admins to pull device info as and when required. This command will be a useful component for CDM APIs as well.

Would we be able to add device logs as part of this remote command? If it is complex, let us revisit later.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35b9ec40290254e484cc17e76ee5205b618e23c9

commit 35b9ec40290254e484cc17e76ee5205b618e23c9
Author: isandrk <isandrk@chromium.org>
Date: Thu Mar 23 10:11:02 2017

Remote fetch device status (attributes and logs) command

This CL introduces a remote command that enables device administrators to remotely fetch device status (attributes and logs). Attributes were being uploaded every 3 hours and logs every 12 hours from the device side, and there was no way to trigger a remote refresh.

More context can be found by reading the design doc go/remote-audio-management

The new functionality was manually tested; remote reboot command was hijacked and rewired to decode into this command and then on the server side (CPanel admin) I clicked on "REBOOT NOW" and I observed the device attributes and logs being updated.

P.S. I've also fixed up some linter errors.

BUG= 686389 
TEST=Manually tested new behaviour.

Review-Url: https://codereview.chromium.org/2765463002
Cr-Commit-Position: refs/heads/master@{#459037}

[modify] https://crrev.com/35b9ec40290254e484cc17e76ee5205b618e23c9/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/35b9ec40290254e484cc17e76ee5205b618e23c9/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h
[add] https://crrev.com/35b9ec40290254e484cc17e76ee5205b618e23c9/chrome/browser/chromeos/policy/remote_commands/device_command_fetch_status_job.cc
[add] https://crrev.com/35b9ec40290254e484cc17e76ee5205b618e23c9/chrome/browser/chromeos/policy/remote_commands/device_command_fetch_status_job.h
[modify] https://crrev.com/35b9ec40290254e484cc17e76ee5205b618e23c9/chrome/browser/chromeos/policy/remote_commands/device_commands_factory_chromeos.cc
[modify] https://crrev.com/35b9ec40290254e484cc17e76ee5205b618e23c9/chrome/browser/chromeos/policy/status_uploader.cc
[modify] https://crrev.com/35b9ec40290254e484cc17e76ee5205b618e23c9/chrome/browser/chromeos/policy/status_uploader.h
[modify] https://crrev.com/35b9ec40290254e484cc17e76ee5205b618e23c9/chrome/browser/chromeos/policy/system_log_uploader.cc
[modify] https://crrev.com/35b9ec40290254e484cc17e76ee5205b618e23c9/chrome/browser/chromeos/policy/system_log_uploader.h
[modify] https://crrev.com/35b9ec40290254e484cc17e76ee5205b618e23c9/components/policy/core/common/remote_commands/remote_command_job.cc
[modify] https://crrev.com/35b9ec40290254e484cc17e76ee5205b618e23c9/components/policy/proto/device_management_backend.proto

Labels: Merge-Request-58
Status: Fixed (was: Assigned)
Summary: Remote command for Device attributes & logs (was: Remote command for Device attributes)
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 24 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 24 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63ec0fbe54d5f9ddb95a1376aec07085f7ba3078

commit 63ec0fbe54d5f9ddb95a1376aec07085f7ba3078
Author: Ivan Sandrk <isandrk@google.com>
Date: Fri Mar 24 12:21:39 2017

Merge of "Remote fetch device status (attributes and logs) command" to M58

This CL introduces a remote command that enables device administrators to remotely fetch device status (attributes and logs). Attributes were being uploaded every 3 hours and logs every 12 hours from the device side, and there was no way to trigger a remote refresh.

More context can be found by reading the design doc go/remote-audio-management

The new functionality was manually tested; remote reboot command was hijacked and rewired to decode into this command and then on the server side (CPanel admin) I clicked on "REBOOT NOW" and I observed the device attributes and logs being updated.

P.S. I've also fixed up some linter errors.

BUG= 686389 
TEST=Manually tested new behaviour.

Review-Url: https://codereview.chromium.org/2765463002
Cr-Commit-Position: refs/heads/master@{#459037}
(cherry picked from commit 35b9ec40290254e484cc17e76ee5205b618e23c9)

Review-Url: https://codereview.chromium.org/2774803003 .
Cr-Commit-Position: refs/branch-heads/3029@{#407}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/63ec0fbe54d5f9ddb95a1376aec07085f7ba3078/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/63ec0fbe54d5f9ddb95a1376aec07085f7ba3078/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h
[add] https://crrev.com/63ec0fbe54d5f9ddb95a1376aec07085f7ba3078/chrome/browser/chromeos/policy/remote_commands/device_command_fetch_status_job.cc
[add] https://crrev.com/63ec0fbe54d5f9ddb95a1376aec07085f7ba3078/chrome/browser/chromeos/policy/remote_commands/device_command_fetch_status_job.h
[modify] https://crrev.com/63ec0fbe54d5f9ddb95a1376aec07085f7ba3078/chrome/browser/chromeos/policy/remote_commands/device_commands_factory_chromeos.cc
[modify] https://crrev.com/63ec0fbe54d5f9ddb95a1376aec07085f7ba3078/chrome/browser/chromeos/policy/status_uploader.cc
[modify] https://crrev.com/63ec0fbe54d5f9ddb95a1376aec07085f7ba3078/chrome/browser/chromeos/policy/status_uploader.h
[modify] https://crrev.com/63ec0fbe54d5f9ddb95a1376aec07085f7ba3078/chrome/browser/chromeos/policy/system_log_uploader.cc
[modify] https://crrev.com/63ec0fbe54d5f9ddb95a1376aec07085f7ba3078/chrome/browser/chromeos/policy/system_log_uploader.h
[modify] https://crrev.com/63ec0fbe54d5f9ddb95a1376aec07085f7ba3078/components/policy/core/common/remote_commands/remote_command_job.cc
[modify] https://crrev.com/63ec0fbe54d5f9ddb95a1376aec07085f7ba3078/components/policy/proto/device_management_backend.proto

Comment 5 by glevin@chromium.org, Apr 18 2017

Cc: yitingc@chromium.org
Labels: Launch-Privacy-Yes
Did a quick, informal privacy review.  This change doesn't send any new information; it just allows the information to be pulled on demand, instead of just pushed periodically.

+yitingc@ FYI

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment