New issue
Advanced search Search tips

Issue 686365 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: [regression] isRegex checkbox is missing on Network and Console filter bars

Project Member Reported by pfeldman@chromium.org, Jan 28 2017

Issue description

I don't see it there.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bae041fd1b08355c53f05729bc384ecae48cb986

commit bae041fd1b08355c53f05729bc384ecae48cb986
Author: einbinder <einbinder@chromium.org>
Date: Mon Jan 30 20:10:48 2017

DevTools: Regex checkbox was missing from filter bars

BUG= 686365 

Review-Url: https://codereview.chromium.org/2659303002
Cr-Commit-Position: refs/heads/master@{#447047}

[modify] https://crrev.com/bae041fd1b08355c53f05729bc384ecae48cb986/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js

Labels: Merge-Request-57
Owner: einbinder@chromium.org
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 31 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 Deleted

Please merge your change to M57 branch 2987 by 5:00 PM PT, Friday 
(02/03) so we can pick it for next week M57 Beta release. Thank you.
Please merge your change to M57 branch 2987 before 5:00 PM Pt, Monday (02/06/) so we can pick it up for next week Beta release. Thank you.
Project Member

Comment 7 by sheriffbot@chromium.org, Feb 6 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Please merge your change to M57 branch 2987 before 5:00 PM PT, Tuesday (02/07/17) so we can pick it up for next Beta release. Thank you.
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 6 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e51624a7bd1c7826b723f7e168e55fe4c1ec479

commit 7e51624a7bd1c7826b723f7e168e55fe4c1ec479
Author: einbinder <einbinder@chromium.org>
Date: Mon Feb 06 22:30:18 2017

DevTools: Regex checkbox was missing from filter bars

BUG= 686365 

Review-Url: https://codereview.chromium.org/2659303002
Cr-Commit-Position: refs/heads/master@{#447047}
(cherry picked from commit bae041fd1b08355c53f05729bc384ecae48cb986)

NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2682503002
Cr-Commit-Position: refs/branch-heads/2987@{#350}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/7e51624a7bd1c7826b723f7e168e55fe4c1ec479/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js

Cc: kkaluri@chromium.org
Labels: Needs-Feedback
Verified this issue on Ubuntu 14.04 with chrome version #55.0.2987.37
Observed that in both console and network tab's Regex checkbox is seen, attaching a screen-cast for reference.

einbinder@ Could you please look into it and confirm that this expected behavior of this CL.

Thank You...
Issue 686365.mp4
1.2 MB View Download
Status: Verified (was: Assigned)
Labels: -Needs-Feedback TE-Verified-57.0.2987.37 TE-Verified-M57
As per comment #11, adding TE-verified Labels

Thank You...
Is it me or the regex bar has disappered again?
I am on Chrome Version 62.0.3202.75 (Official Build) (64-bit)

A+
Same for me, regex checkbox has disappeared.
Version 62.0.3202.75 (Official Build) (64-bit)

Comment 15 by dany...@gmail.com, Nov 18 2017

no regexp too

Version 62.0.3202.94 (Official Build) (64-bit) MAC

Comment 16 by kayce@google.com, Dec 13 2017

RegEx is working for me in the "Filter" text box if I just enclose my query in forward-slashes. See pic.

Google Chrome	65.0.3292.0 (Official Build) canary (64-bit)
Revision	7d40cf8237fbf29b3dffb6dca3376c10c3df176b-refs/heads/master@{#523290}
OS	Mac OS X
Screen Shot 2017-12-13 at 2.54.01 PM.png
253 KB View Download

Sign in to add a comment