Evan, would you be a better owner for this? It would be really good if we could get a fix back into m-57.

I need the configuración for my Moto G3

I can own this but why target m57? It's pretty subtle.

If you think it looks OK on low-dpi devices then it doesn't seem super high priority to me. I haven't seen it -- I don't have a low-dpi device on my desk.

Sounds low-priority to me too. We constantly break subpixel rendering in the omnibox, which is much more noticeable, and nobody except me cares. :-/

I'm attaching a screenshot showing how things look on a ToT lumpy build. I have to look really, really closely to tell which text is missing subpixel rendering.

(Spoiler: just "US Dvorak keyboard", "Connected to Ethernet", and the date, I think)

Deleted: Screenshot 2017-01-31 at 16.25.27.png 92.3 KB

	Screenshot 2017-01-31 at 16.25.27.png 92.3 KB View Download

SetupLabelForTray() in tray_utils.cc is applied to labels that are in the tray, not the system menu, i.e. white text. I don't think subpixel rendering does anything to white text.

For System menu labels check out TrayPopupUtils::CreateDefaultLabel().

I don't think there's any inherent reason we can't use subpixel rendering for white text (and I believe that we already do by default), although it may look worse than dark-colored text on a light background (for complicated reasons involving gamma that I don't understand). The tray has a transparent background, though, so we can't use it there.

I think I was confused by the fact that my system wasn't properly doing subpixel at all anywhere. But wrt the tray labels, I did find that function and it seems like the best fix is also the simplest one, which is to just add backgrounds to the labels. We could add backgrounds instead to anything that holds a label, but I'm not sure what win that would provide --- it's just one more step you have to remember to do (even if we make a utility function called TrayPopupUtils::ConfigureRow or whatever).  This doesn't break ripples or anything else I can find.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47a9403d16ca37b99175b07cea5ee41c574d36c5

commit 47a9403d16ca37b99175b07cea5ee41c574d36c5
Author: estade <estade@chromium.org>
Date: Wed Feb 01 18:57:56 2017

Apply subpixel rendering to labels in cros system menu.

BUG= 686363 

Review-Url: https://codereview.chromium.org/2667963006
Cr-Commit-Position: refs/heads/master@{#447565}

[modify] https://crrev.com/47a9403d16ca37b99175b07cea5ee41c574d36c5/ash/common/system/chromeos/ime_menu/ime_list_view.cc
[modify] https://crrev.com/47a9403d16ca37b99175b07cea5ee41c574d36c5/ash/common/system/tray/tray_popup_utils.cc

Based on the discussion it seems ok to just leave this in m-58 and not merge back to 57.