DevTools: Searching f:front_end maxWidth does not return Toolbar.js |
||
Issue descriptionSearch across files is broken
,
Jan 30 2017
,
Jan 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0dee95e08944e4ca548b5bf874d34a3695fc7a93 commit 0dee95e08944e4ca548b5bf874d34a3695fc7a93 Author: lushnikov <lushnikov@chromium.org> Date: Tue Jan 31 05:47:13 2017 DevTools: fix search across all files in case of "file:" prefix Search across files supports narrowing of the search scope with the "file:" pattern. For example: [1] file:front_end QUERY [2] QUERY file:front_end The bug happens only in the [1] case, when the query is prefixed with "file:" pattern. In this case, we currently consider the query to be " foobar" instead of "foobar" (e.g. containing excessive space in front). This patch swallows all the whitespaces around the "file:" pattern so that they are not included in the actual search queries. BUG= 686359 R=dgozman Review-Url: https://codereview.chromium.org/2660853002 Cr-Commit-Position: refs/heads/master@{#447196} [modify] https://crrev.com/0dee95e08944e4ca548b5bf874d34a3695fc7a93/third_party/WebKit/LayoutTests/inspector/sources/search-config-expected.txt [modify] https://crrev.com/0dee95e08944e4ca548b5bf874d34a3695fc7a93/third_party/WebKit/LayoutTests/inspector/sources/search-config.html [modify] https://crrev.com/0dee95e08944e4ca548b5bf874d34a3695fc7a93/third_party/WebKit/Source/devtools/front_end/workspace/SearchConfig.js
,
Jan 31 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by lushnikov@chromium.org
, Jan 28 2017