New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 686345 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 686343
issue 708190



Sign in to add a comment

Cleanup of non-MD code in HoverHighlightView

Project Member Reported by tdander...@chromium.org, Jan 28 2017

Issue description

Clean up the non-MD code paths in the HoverHighlightView class.

 
Blocking: 686347
Labels: -Pri-2 Pri-1
Owner: tdander...@chromium.org
Status: Assigned (was: Available)
Labels: Hotlist-CodeHealth
Status: Started (was: Assigned)
First pass cleanup CL: https://codereview.chromium.org/2696033003/
Labels: -Pri-1 Pri-2
Labels: -M-58 M-59
Status: Assigned (was: Started)
Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5360eea373d896d8916087952ace99ed2a7ff05a

commit 5360eea373d896d8916087952ace99ed2a7ff05a
Author: tdanderson <tdanderson@chromium.org>
Date: Mon Apr 03 21:17:32 2017

[Ash] Remove HoverHighlightView::hover()

As part of the material design rework of the system menu,
the |hover_| member of HoverHighlightView was no longer
being updated. However both the network submenu and the
VPN submenu were accessing this member (via hover()) to
keep currently-hovered menu rows visible during an update
to the network/VPN list. Remove hover() and instead call
View::IsMouseHovered() at its call sites instead to
restore the intended behavior.

BUG= 686345 
TEST=manual

Review-Url: https://codereview.chromium.org/2789253002
Cr-Commit-Position: refs/heads/master@{#461543}

[modify] https://crrev.com/5360eea373d896d8916087952ace99ed2a7ff05a/ash/common/system/chromeos/network/network_list_delegate.h
[modify] https://crrev.com/5360eea373d896d8916087952ace99ed2a7ff05a/ash/common/system/chromeos/network/network_list_md.cc
[modify] https://crrev.com/5360eea373d896d8916087952ace99ed2a7ff05a/ash/common/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/5360eea373d896d8916087952ace99ed2a7ff05a/ash/common/system/chromeos/network/network_state_list_detailed_view.h
[modify] https://crrev.com/5360eea373d896d8916087952ace99ed2a7ff05a/ash/common/system/chromeos/network/vpn_list_view.cc
[modify] https://crrev.com/5360eea373d896d8916087952ace99ed2a7ff05a/ash/common/system/tray/hover_highlight_view.h

Blocking: 708190
Blocking: -686347
Remove mention of MaterialDesignController, perform preliminary cleanup: https://codereview.chromium.org/2795143005/

Further code cleanup tracked in  issue 708190 
Project Member

Comment 15 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/889fe85b1ec6deaef84f7c1b3a186aa0a7a3f7f5

commit 889fe85b1ec6deaef84f7c1b3a186aa0a7a3f7f5
Author: tdanderson <tdanderson@chromium.org>
Date: Wed Apr 05 14:30:37 2017

[Ash] Remove pre-MD code paths from HoverHighlightView

This CL removes all mention of ash::MaterialDesignController
from the HoverHighlightView class and performs some
preliminary cleanup of dead code. Further refactoring
and code cleanup for this class requires some additional
investigation and is tracked by  crbug.com/708190 .

BUG= 686345 
TEST=manual

Review-Url: https://codereview.chromium.org/2795143005
Cr-Commit-Position: refs/heads/master@{#462064}

[modify] https://crrev.com/889fe85b1ec6deaef84f7c1b3a186aa0a7a3f7f5/ash/common/system/chromeos/audio/audio_detailed_view.cc
[modify] https://crrev.com/889fe85b1ec6deaef84f7c1b3a186aa0a7a3f7f5/ash/common/system/chromeos/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/889fe85b1ec6deaef84f7c1b3a186aa0a7a3f7f5/ash/common/system/chromeos/cast/tray_cast.cc
[modify] https://crrev.com/889fe85b1ec6deaef84f7c1b3a186aa0a7a3f7f5/ash/common/system/chromeos/ime_menu/ime_list_view.cc
[modify] https://crrev.com/889fe85b1ec6deaef84f7c1b3a186aa0a7a3f7f5/ash/common/system/chromeos/network/network_info.h
[modify] https://crrev.com/889fe85b1ec6deaef84f7c1b3a186aa0a7a3f7f5/ash/common/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/889fe85b1ec6deaef84f7c1b3a186aa0a7a3f7f5/ash/common/system/chromeos/network/vpn_list_view.cc
[modify] https://crrev.com/889fe85b1ec6deaef84f7c1b3a186aa0a7a3f7f5/ash/common/system/chromeos/palette/common_palette_tool.cc
[modify] https://crrev.com/889fe85b1ec6deaef84f7c1b3a186aa0a7a3f7f5/ash/common/system/tray/hover_highlight_view.cc
[modify] https://crrev.com/889fe85b1ec6deaef84f7c1b3a186aa0a7a3f7f5/ash/common/system/tray/hover_highlight_view.h
[modify] https://crrev.com/889fe85b1ec6deaef84f7c1b3a186aa0a7a3f7f5/ash/common/system/tray/label_tray_view.cc
[modify] https://crrev.com/889fe85b1ec6deaef84f7c1b3a186aa0a7a3f7f5/ash/common/system/tray/tray_constants.cc
[modify] https://crrev.com/889fe85b1ec6deaef84f7c1b3a186aa0a7a3f7f5/ash/common/system/tray/tray_constants.h
[modify] https://crrev.com/889fe85b1ec6deaef84f7c1b3a186aa0a7a3f7f5/ash/common/system/tray_accessibility.cc
[modify] https://crrev.com/889fe85b1ec6deaef84f7c1b3a186aa0a7a3f7f5/ash/common/system/tray_accessibility.h

Status: Fixed (was: Started)
Labels: code-change
Status: Verified (was: Fixed)

Sign in to add a comment