A handful of TrayBackgroundView subclasses implement ShouldBlockShelfAutoHide() in a seemingly identical way, which presents an opportunity for refactoring.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6806c795184e4012764bf389f63f95c4e266d382 commit 6806c795184e4012764bf389f63f95c4e266d382 Author: estade <estade@chromium.org> Date: Wed Apr 26 16:27:22 2017 Remove ShouldBlockShelfAutoHide(). Instead, don't auto-hide the shelf if any TrayBubbleView is open. I considered making this check if any TrayBackgroundView is active, but some like the virtual keyboard can be active without wanting to block the shelf from auto hiding. BUG= 686341 Review-Url: https://codereview.chromium.org/2831233003 Cr-Commit-Position: refs/heads/master@{#467342} [modify] https://crrev.com/6806c795184e4012764bf389f63f95c4e266d382/ash/system/ime_menu/ime_menu_tray.cc [modify] https://crrev.com/6806c795184e4012764bf389f63f95c4e266d382/ash/system/ime_menu/ime_menu_tray.h [modify] https://crrev.com/6806c795184e4012764bf389f63f95c4e266d382/ash/system/ime_menu/ime_menu_tray_unittest.cc [modify] https://crrev.com/6806c795184e4012764bf389f63f95c4e266d382/ash/system/palette/palette_tray.cc [modify] https://crrev.com/6806c795184e4012764bf389f63f95c4e266d382/ash/system/palette/palette_tray.h [modify] https://crrev.com/6806c795184e4012764bf389f63f95c4e266d382/ash/system/status_area_widget.cc [modify] https://crrev.com/6806c795184e4012764bf389f63f95c4e266d382/ash/system/web_notification/web_notification_tray.cc [modify] https://crrev.com/6806c795184e4012764bf389f63f95c4e266d382/ui/views/bubble/tray_bubble_view.cc [modify] https://crrev.com/6806c795184e4012764bf389f63f95c4e266d382/ui/views/bubble/tray_bubble_view.h
Comment 1 by tdander...@chromium.org
, Feb 7 2017