New issue
Advanced search Search tips

Issue 686330 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-01-27
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 671375



Sign in to add a comment

a11y: 2 unlabeled buttons for “Get Help” and “Report an issue”

Project Member Reported by chaok@google.com, Jan 28 2017

Issue description

about page 
2 unlabeled buttons for “Get Help” and “Report an issue”

Chrome Version: Chrome 58.0.2994.0
OS: Windows 10
Screen Reader: NVDA 2016.4, JAWS 18.0.2324

What steps will reproduce the problem?
(1) Install NVDA via http://www.nvaccess.org/ 
(2) chrome://md-settings
(3) Main Menu > About > B to navigate by buttons

What is the expected result?
Get help, button
Report an issue, button

What is the observed result?
Button
Button
 

Comment 1 by dbeam@chromium.org, Feb 9 2017

Blocking: 671375
Labels: -Pri-1 Pri-2
Status: Available (was: Untriaged)

Comment 2 by dbeam@chromium.org, Feb 9 2017

demoted because you filed this as "Get help" and "Report an issue" are unlabeled

well, they seem to be labelled enough by their text that you probably understood their purpose, no?

Comment 3 by chaok@google.com, Feb 9 2017

Labels: -Pri-2 Pri-1
No, when using TAB or control navigation--these are reported as "button", so no-label.
THis violates: 1.1. Do all controls and images have meaningful labels?

Comment 4 by dbeam@chromium.org, Feb 11 2017

Cc: hcarmona@chromium.org
Owner: dbeam@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/610b2e126ebb150af06f8400c73e6341c32cddb7

commit 610b2e126ebb150af06f8400c73e6341c32cddb7
Author: dbeam <dbeam@chromium.org>
Date: Mon Feb 13 19:20:17 2017

MD Settings: label and describe a bunch of subpage/open-in-new buttons

R=hcarmona@chromium.org
BUG= 686330 , 686327 , 686309 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2689053002
Cr-Commit-Position: refs/heads/master@{#450038}

[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/a11y_page/a11y_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/a11y_page/manage_a11y_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/date_time_page/date_time_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/device_page/device_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/device_page/display.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/device_page/keyboard.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/device_page/storage.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/device_page/stylus.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/internet_page/internet_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/internet_page/network_summary_item.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/people_page/lock_screen.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/people_page/sync_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/printing_page/cloud_printers.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/printing_page/printing_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/reset_page/reset_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/search_page/search_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/site_settings/site_data.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/site_settings_page/site_settings_page.html

Comment 7 by dbeam@chromium.org, Feb 28 2017

Status: Fixed (was: Started)

Sign in to add a comment