New issue
Advanced search Search tips

Issue 686327 link

Starred by 1 user
Status: Fixed
Owner:
dbeam@chromium.org
Closed: Mar 2017
Cc:
hcarmona@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: 2017-01-27
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 671375



Sign in to add a comment

a11y: Advanced has 21 unlabeled buttons

Project Member Reported by chaok@google.com, Jan 28 2017 
accessing advanced
21 unlabeled-buttons (buttons and toggle button pressed/not pressed)
Repros w/ JAWS 18, but it assignsa random number to unlabeled buttons

Chrome Version: Chrome 58.0.2994.0
OS: Windows 10
Screen Reader: NVDA 2016.4, JAWS 18.0.2324

What steps will reproduce the problem?
(1) Install NVDA via http://www.nvaccess.org/ or JAWS via http://www.freedomscientific.com/
(2) chrome://md-settings
(3) Expand Advanced Settings > B to navigate by buttons

What is the expected result?
A11y-label/label for control that is associated to on-screen text

What is the observed result?
Unlabeled/random number for controls

Comment 1 by dbeam@chromium.org, Feb 9 2017

Blocking: 671375
Status: Available (was: Untriaged)

Comment 2 by dbeam@chromium.org, Feb 11 2017

Cc: hcarmona@chromium.org
Owner: dbeam@chromium.org
Status: Started (was: Available)
these are all our subpage and open-in-new buttons
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/610b2e126ebb150af06f8400c73e6341c32cddb7

commit 610b2e126ebb150af06f8400c73e6341c32cddb7
Author: dbeam <dbeam@chromium.org>
Date: Mon Feb 13 19:20:17 2017

MD Settings: label and describe a bunch of subpage/open-in-new buttons

R=hcarmona@chromium.org
BUG= 686330 , 686327 , 686309 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2689053002
Cr-Commit-Position: refs/heads/master@{#450038}

[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/a11y_page/a11y_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/a11y_page/manage_a11y_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/date_time_page/date_time_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/device_page/device_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/device_page/display.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/device_page/keyboard.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/device_page/storage.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/device_page/stylus.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/internet_page/internet_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/internet_page/network_summary_item.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/people_page/lock_screen.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/people_page/sync_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/printing_page/cloud_printers.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/printing_page/printing_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/reset_page/reset_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/search_page/search_page.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/site_settings/site_data.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/610b2e126ebb150af06f8400c73e6341c32cddb7/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/878954073e38da75b13a8d1299eb0e51e2440dab

commit 878954073e38da75b13a8d1299eb0e51e2440dab
Author: dbeam <dbeam@chromium.org>
Date: Tue Mar 07 17:42:56 2017

MD Settings: add an aria-label to control indicators (often policy)

R=hcarmona@chromium.org
BUG= 686327 , 686309 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2720413002
Cr-Commit-Position: refs/heads/master@{#455120}

[modify] https://crrev.com/878954073e38da75b13a8d1299eb0e51e2440dab/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/878954073e38da75b13a8d1299eb0e51e2440dab/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html
[modify] https://crrev.com/878954073e38da75b13a8d1299eb0e51e2440dab/chrome/browser/resources/settings/controls/controlled_button.html
[modify] https://crrev.com/878954073e38da75b13a8d1299eb0e51e2440dab/chrome/browser/resources/settings/controls/controlled_button.js
[modify] https://crrev.com/878954073e38da75b13a8d1299eb0e51e2440dab/chrome/browser/resources/settings/controls/controlled_radio_button.html
[modify] https://crrev.com/878954073e38da75b13a8d1299eb0e51e2440dab/chrome/browser/resources/settings/controls/controlled_radio_button.js
[modify] https://crrev.com/878954073e38da75b13a8d1299eb0e51e2440dab/chrome/browser/resources/settings/controls/settings_checkbox.html
[modify] https://crrev.com/878954073e38da75b13a8d1299eb0e51e2440dab/chrome/browser/resources/settings/controls/settings_input.html
[modify] https://crrev.com/878954073e38da75b13a8d1299eb0e51e2440dab/chrome/browser/resources/settings/controls/settings_toggle_button.html
[modify] https://crrev.com/878954073e38da75b13a8d1299eb0e51e2440dab/chrome/browser/resources/settings/date_time_page/date_time_page.html
[modify] https://crrev.com/878954073e38da75b13a8d1299eb0e51e2440dab/chrome/browser/resources/settings/downloads_page/downloads_page.html
[modify] https://crrev.com/878954073e38da75b13a8d1299eb0e51e2440dab/chrome/browser/resources/settings/on_startup_page/on_startup_page.html
[modify] https://crrev.com/878954073e38da75b13a8d1299eb0e51e2440dab/chrome/browser/resources/settings/system_page/system_page.html
[modify] https://crrev.com/878954073e38da75b13a8d1299eb0e51e2440dab/chrome/test/data/webui/settings/on_startup_browsertest.js
[modify] https://crrev.com/878954073e38da75b13a8d1299eb0e51e2440dab/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.html
[modify] https://crrev.com/878954073e38da75b13a8d1299eb0e51e2440dab/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js

Comment 6 by dbeam@chromium.org, Mar 7 2017

Status: Fixed (was: Started)
so, with the exception of chromeos, pretty much everything has a label.

file specific bugs if you find stuff that doesn't.
►

Sign in to add a comment