New issue
Advanced search Search tips

Issue 686294 link

Starred by 2 users
Status: Verified
Owner:
est...@chromium.org
Closed: Feb 2017
Cc:
varkha@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Cleanup of non-MD code related to the Ash system menu user row

Project Member Reported by tdander...@chromium.org, Jan 27 2017 
Cleanup of non-MD code related to the Ash system menu user row, including but not limited to:

* user_card_view.cc
* user_view.cc
* tray_user.cc
* rounded_image_view.cc
* button_from_view.cc

Comment 1 by tdander...@chromium.org, Jan 28 2017 

As a bonus, consider refactoring opportunities for the similar classes RoundedRectView, RoundedContainerView, and RoundedImageView.

Comment 2 by tdander...@chromium.org, Feb 7 2017

Labels: Hotlist-CodeHealth

Comment 3 by tdander...@chromium.org, Feb 10 2017 

Side note FTR, looks like all of PopupView can also be ripped out as part of these changes, at which point we'll no longer need IDR_AURA_WARNING_ICON.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8822da076b4fa3a4e98bc2136309c449f4645a4c

commit 8822da076b4fa3a4e98bc2136309c449f4645a4c
Author: estade <estade@chromium.org>
Date: Sat Feb 11 01:11:02 2017

Remove pre-MD code related to tray/menu user profiles.

TBR=derat@chromium.org
BUG= 686294 

Review-Url: https://codereview.chromium.org/2678353005
Cr-Commit-Position: refs/heads/master@{#449813}

[modify] https://crrev.com/8822da076b4fa3a4e98bc2136309c449f4645a4c/ash/BUILD.gn
[modify] https://crrev.com/8822da076b4fa3a4e98bc2136309c449f4645a4c/ash/ash_strings.grd
[modify] https://crrev.com/8822da076b4fa3a4e98bc2136309c449f4645a4c/ash/common/frame/custom_frame_view_ash_unittest.cc
[modify] https://crrev.com/8822da076b4fa3a4e98bc2136309c449f4645a4c/ash/common/system/tray/system_tray.cc
[modify] https://crrev.com/8822da076b4fa3a4e98bc2136309c449f4645a4c/ash/common/system/tray/tray_constants.cc
[modify] https://crrev.com/8822da076b4fa3a4e98bc2136309c449f4645a4c/ash/common/system/tray/tray_constants.h
[modify] https://crrev.com/8822da076b4fa3a4e98bc2136309c449f4645a4c/ash/common/system/user/button_from_view.cc
[modify] https://crrev.com/8822da076b4fa3a4e98bc2136309c449f4645a4c/ash/common/system/user/button_from_view.h
[modify] https://crrev.com/8822da076b4fa3a4e98bc2136309c449f4645a4c/ash/common/system/user/rounded_image_view.cc
[modify] https://crrev.com/8822da076b4fa3a4e98bc2136309c449f4645a4c/ash/common/system/user/rounded_image_view.h
[modify] https://crrev.com/8822da076b4fa3a4e98bc2136309c449f4645a4c/ash/common/system/user/tray_user.cc
[delete] https://crrev.com/6e8bfa3991a15be001ac300469bc5e7c49e34d57/ash/common/system/user/tray_user_separator.cc
[delete] https://crrev.com/6e8bfa3991a15be001ac300469bc5e7c49e34d57/ash/common/system/user/tray_user_separator.h
[modify] https://crrev.com/8822da076b4fa3a4e98bc2136309c449f4645a4c/ash/common/system/user/user_card_view.cc
[modify] https://crrev.com/8822da076b4fa3a4e98bc2136309c449f4645a4c/ash/common/system/user/user_card_view.h
[modify] https://crrev.com/8822da076b4fa3a4e98bc2136309c449f4645a4c/ash/common/system/user/user_view.cc
[modify] https://crrev.com/8822da076b4fa3a4e98bc2136309c449f4645a4c/ash/common/system/user/user_view.h
[modify] https://crrev.com/8822da076b4fa3a4e98bc2136309c449f4645a4c/ash/resources/ash_resources.grd
[delete] https://crrev.com/6e8bfa3991a15be001ac300469bc5e7c49e34d57/ash/resources/default_100_percent/cros/status/multiprofiles_add.png
[delete] https://crrev.com/6e8bfa3991a15be001ac300469bc5e7c49e34d57/ash/resources/default_100_percent/cros/status/status_guest_icon.png
[delete] https://crrev.com/6e8bfa3991a15be001ac300469bc5e7c49e34d57/ash/resources/default_200_percent/cros/status/multiprofiles_add.png
[delete] https://crrev.com/6e8bfa3991a15be001ac300469bc5e7c49e34d57/ash/resources/default_200_percent/cros/status/status_guest_icon.png

Comment 6 by est...@chromium.org, Feb 16 2017

Cc: varkha@chromium.org
Status: Fixed (was: Assigned)
> As a bonus, consider refactoring opportunities for the similar classes RoundedRectView, RoundedContainerView, and RoundedImageView.

There are TODOs for this in the code and I don't really consider this task to be part of removing pre-md code.

Comment 7 by rookrishna@chromium.org, Mar 29 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment